Skip to content

chore: file the comment-only and glued attribute value item - #265

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-w1-agent-feedback-0knu2t
Nov 5, 2026
Merged

DylanPiercey merged 1 commit into
mainfrom
dpiercey-w1-agent-feedback-0knu2t

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Moves an agent-feedback item here from marko-js/marko: three ordinary attribute mistakes (a comment-only value, a value cut off after its leading comment, and a string glued to the next attribute) reach Babel as one value and report generic expression errors. The parser sees each where the value ends, so it can name the mistake.

🤖 Generated with Claude Code

Moved from marko's agent feedback, since the fix belongs in the parser.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8ed2139

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DylanPiercey
DylanPiercey merged commit cfc3e38 into main Nov 5, 2026
8 of 9 checks passed
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.89%. Comparing base (9ea6c77) to head (8ed2139).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          35       35           
  Lines        4758     4758           
  Branches      921      921           
=======================================
  Hits         4753     4753           
  Misses          4        4           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant