Fix missing time boundary guard in TestJumpToDateEndpoint - #917
Merged
Conversation
Comment on lines
365
to
367
| time.Sleep(tsBoundaryGuard) // ensure timeBeforeEventA is AFTER the initial creation events | ||
| timeBeforeEventA := time.Now() | ||
| time.Sleep(tsBoundaryGuard) |
Contributor
There was a problem hiding this comment.
Fix regression introduced in #872
This isn't a regression.
Whilst #872 tried to fix this, the review process reintroduced the bug for one specific scenario
I specifically pointed this out in review #872 (comment) but it was never addressed and you approved/merged the PR.
Contributor
There was a problem hiding this comment.
This was resolved but the PR title/description was never updated.
I've just made some light touches 🤷
jevolk
approved these changes
Sep 8, 2026
MadLittleMods
changed the title
TestJumpToDateEndpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst #872 tried to fix this,
the review process reintroduced the bugfor one specific scenario: when the initial room creation events are in the same millisecond as the event "before A". Without this extra sleep,timeBeforeEventAmay actually be the "time exactly at the last initial creation events" which is Bad since it then messes up which events get returned.Pull Request Checklist