Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ci.yamlreusable workflow declares fiveEE_DB_*secrets as required, although this workflow never reads them. In sharded mode its control-onlyut-linux-x86job checks the four shard results but does not select thecienvironment where those secrets are configured. The previous MatrixOne run 34916576954 completed all four UT shards, then failed the established UT check at this summary boundary.Change
Keep the
EE_DB_*names available to callers but make them optional for this workflow. The UT jobs still select thecienvironment, and the S3 secrets used by UT remain required. The independentutils.yamlandmerge-update-moc.yamlcontracts are unchanged.Validation
.github/workflows/ci.yaml(release archive SHA-256 verified)git diff --check