Repository navigation
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #625. Refs matrixorigin/matrixone-doc#578.
Summary
Explain that Ended=True can indicate a failed backup: require phase=Completed and status.backup, then validate restoration independently. Add pinned chart/CRD/image records, server dry-run, database readiness checks and upgrade/deletion/retention boundaries.
Verification
At Operator base 10aef15: helm dependency build, helm lint (0 failed), and helm template with Helm 3.17.3. Checked added shell blocks with bash -n and checked failBackup/completeBackup controller logic. git diff --check passed.
Scope Notes
No Kubernetes cluster was available for server dry-run, deployment, failover, upgrades or retention tests. Those operations are explicitly described as separate acceptance work; Helm render is not lifecycle certification.