Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP
cleantool asks agents to show a dry run and get the user's approval beforeapply: true, but the server did not enforce it. An agent could callapplydirectly, or apply a selection different from the one the user saw.A dry run now returns a
preview_token.applyrequires the token and the same arguments, scans again, and deletes nothing unless the new selection matches the dry run: the same project cache paths with the same rules, projects, sizes, and modification times, or the same global rules with the same paths, actions, and targets. Otherwise it returns an error that lists each added, removed, or changed entry. Global cache sizes are not compared, because every build changes them; the Xcode rule's folders and their size are compared.The server keeps up to 16 previews in memory under random tokens. A token works for one
applycall and expires 30 minutes after its dry run, because the dry run the user approved is probably out of date by then. The comparison runs on the same scan thatapplydeletes from, through a newConfirmhook in the engine, and every existing safety check still runs before each deletion. The command-lineclean --applyis unchanged, because the README does not promise this guarantee there.