Repository navigation
Conversation
Use decreasing encounter indices and preserve reverse-key equality. Add regression coverage for stable ties and shared non-reflexive keys. AI-assisted implementation and independent review. Refs maxfischer2781#241
Owner
|
Hi @AlexXuz, thanks for the bug report and solution draft. Please be mindful that AI-assisted contributions don't have the best track record here and that I am aware your attention is spread over dozens of PRs. I have given your PR a first run of inspections. Please mark it as ready for review once appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves input order for equal-key records returned by
nlargestandnsmallest.ReverseLTso tuple comparisons can use their encounter index.Closes #241
Validation on Linux:
Other Python versions and operating systems were not run locally. The change does not modify
mergeor the active work in #238. AI-assisted contribution with independent correctness review.