Skip to content

Windows: validate directory rejection with simulated reparse metadata without link fixtures #2924

Closed

Description

@mblua

The Windows verify_directory_reason_rejects_reparse_component test creates real symbolic links and junctions. On the current development host, symbolic-link creation fails with Windows error 1314, blocking validation of #2892 despite the unchanged production behavior.

The user requested an alternative without links for this specific correction, approved preparation and coverage review, and explicitly authorized a Git worktree for this workaround while P01 remains suspended. Other pre-existing link tests remain unchanged; their future correction is tracked separately in #2922.

Scope: src-tauri/src/path_identity.rs and .github/workflows/pr-regression-gates.yml. Use the architect-reviewed private shared verification algorithm with simulated Windows reparse metadata, preserve exact typed errors and ordinary-directory controls, and explicitly reconcile the obsolete AC_REQUIRE_WINDOWS_LINK_TESTS producer/consumer. Public production behavior must remain unchanged.

Coverage limitation: simulation does not verify real Windows symbolic-link/junction metadata or the corresponding filesystem integration. Declare this loss explicitly; no claim of equivalent integration coverage, skipped tests, privilege changes or CI waiver.

Candidate: .ac/plans/2432-identity-layers/plan-v4-windows-no-links-test.md, SHA256 4a1f40ceb7d6e4849146cf74165283a132b1a5c160efede78f527ea7ccdebb7b. Rust and Grinch approved its design; the delivery sequence is being updated for the authorized worktree exception. Implementation must follow the final frozen, approved plan and normal verification gates.

Deliver independently, then integrate the landed correction into the preserved P01 branch. Do not close #2432 or #2892 with the corrective PR. No distribution build requested.

Activity

  1. added
    bugSomething isn't working
    windowsAffected platform: the behaviour occurs on or is specific to Windows
    on Oct 6, 2026
  2. added a commit that references this issue on Oct 7, 2026
  3. mblua commented on Oct 7, 2026

    @mblua
    OwnerAuthor

    Delivered via #2928, merged as aa9dfd4.

    The targeted Windows reparse test now uses simulated metadata without creating links; the spawn inventory reflects the removed test constructor. Other link fixtures remain unchanged (follow-up #2922).

    Final review PASS on 2390b48. All 14 required checks and all triggered checks passed on that exact head, including frontend regression, Windows/Linux/macOS and SonarCloud. No distribution build was requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingwindowsAffected platform: the behaviour occurs on or is specific to Windows

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions