Skip to content

Recognize empty Clean descriptions in room menus #2935

Closed

Description

@mblua

Part of #2930. P01, patterned; owner ac-dev-webpage-ui-v4; no dependencies. Existing Clean disabled detection recognizes the old placeholder, but treats an empty description as dirty. Recognize exact empty descriptions while retaining existing guards and legacy compatibility; whitespace remains cleanable. Do not mutate snapshots.

Files: src/sidebar/components/ProjectPanel.tsx, ProjectPanel.context-menu.test.tsx, src/sidebar/stores/project.test.ts.

Acceptance: both active/inactive menus disable Clean for canonical empty state; legacy behavior and status/unknown guards remain; whitespace and human descriptions remain cleanable; paired-null/stale-response regression retained.

Validation from repo root: npm test -- src/sidebar/components/ProjectPanel.context-menu.test.tsx src/sidebar/stores/project.test.ts; npm run typecheck; npm run check:frontend-dependencies; applicable architecture checks and exact-head CI specified in approved plan.

Canonical specification: D:/0_repos/AgentsCommander_iac/.ac/plans/2930-empty-task-description/P01-v3-ui-empty-description.md. Phase-SHA256 769B234951DAA1864DAA5829BD10A1BAD0A7E4410995E7F62534093329BC376C. Human approval of the exact set still pending; no implementation authorized yet.

Activity

  1. added a commit that references this issue on Oct 7, 2026
  2. mblua commented on Oct 7, 2026

    @mblua
    OwnerAuthor

    P01 I2935 delivered

    PR #2938 MERGED; child2935 CLOSED. Tested head8ec20eeaeb7268ac4b9129384947abbe6fef443a; merge49f6230a5f3d18f6c56dcd244467114e63543520. Local main==origin/main49f6230 clean, branch cleanup complete; remote refs only origin/HEAD/main.

    Grinch PASS, tests143/143 and relevant local checks, PRE/POST arcs identical. On CI notice, gh run list showed all5workflows completed success at exacthead; gh pr checks all applicable PASS. Full-only jobs skipped under workflow ci-tier.outputs.full condition, no unaccounted skip. Step9.5 fresh main ancestor and no incoming delta; admin merge approved flow. No build final requested.

    P01 Visual app change disabled/tooltip, DOM matrices both menus validated. Full v3 plan identity unchanged. Epic2930 still open; P02 child2936 depends on this merged commit; P03 child2937 dependsP02. Before P02: mandatory self-handoff-and-clear per Role between tickets; then verify plan/mapping/human approval, sync main/ancestry, fresh phase purge, delegate Rust cold. No work remains in flight; concrete dev/Grinch reports received and peers idle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions