Skip to content

Write canonical command fields and clarify base/profile labels #3021

Closed

Description

@mblua

Situation and intended change

Native phase P03 of #3018 (under E2432). After backend support lands, adapt update/saveDraft/updateCodingAgentProfiles payloads to canonical names. Clarify Base command and Additional arguments labels while keeping the composed Command preview, validation and internal consumers.

Class: design-bearing. Source owner: ac-dev-webpage-ui-v5. Depends on: P02. Sequential fresh branch from main after dependency merge/ancestry.

Files

  • src/shared/types.ts
  • src/shared/ipc.ts
  • src/shared/ipc.transport.test.ts
  • src/sidebar/components/SettingsModal.tsx
  • src/sidebar/components/AgentPickerModal.tsx
  • src/sidebar/components/SettingsModal.validate-agents.test.tsx
  • src/sidebar/components/AgentPickerModal.test.tsx

Mandatory acceptance

  1. Follow the exact approved phase, scope, ownership and green boundary; no new design decision.
  2. New field with content wins; otherwise legacy fallback. Identical frozen W predicate across runtimes; validate present values and preserve selected original text.
  3. Authorized updates write new fields only; retain current-source old key/value unchanged. No delete/update/synthesize old values, no write on read or new source authority.
  4. Preserve fixed base arguments/wrappers, parsing, launch text, metadata, references and current identity/hash inputs. No packaged build/install/release/version bump.
  5. Ship the phase proof/check receipts and exact-head applicable CI; PR closes only this child, never Clarify agent and profile command fields with new-first legacy fallback #3018. Shipper alone executes phase npm/Cargo/structural verification; developer owns source/fixtures/mutation edits and interpretation. Negative controls must fail before restored green evidence.

Canonical approved specification

Root: D:/0_repos/AgentsCommander_iac/.ac/plans/3018-command-fields/plan-v5-command-fields.md
Plan-SHA256: 6562A0C615AAB37A6A245C9FCDC0400922BE3A94C7D85B3383724A133A554305
Phase: D:/0_repos/AgentsCommander_iac/.ac/plans/3018-command-fields/p03-v4-frontend-writes.md
Phase-SHA256: A507042CA993C757DDBC6C5B76F4CAB71F12FFF8DC77A0D773B474C2B8BE5053
Five fresh approvals: room-shared/i3018-command-fields/round8-v5-consensus.md. Standing user authorization, exact mapping receipt and cold gates govern execution; plans are immutable.

Verification

Run from room-19 repo-AgentsCommander; complete inventory/positive-negative proof and executor in the phase file.

timeout 1200 npm run typecheck
timeout 1200 npm test -- src/shared/ipc.transport.test.ts src/shared/profile-utils.test.ts src/sidebar/components/SettingsModal.validate-agents.test.tsx src/sidebar/components/AgentPickerModal.test.tsx
timeout 1200 npm run check:frontend-dependencies
timeout 1200 npm run build

Layer distinction in v4: persisted Rust retains required-base/profile-default validation; frontend response projection preserves absent fields/collections/empty profile objects and no-op identity. Both present values remain strictly validated. Preserve the P01 reader and every existing consumer assertion; no default synthesis or new source authority.

Activity

  1. added a commit that references this issue on Oct 16, 2026
  2. mblua commented on Oct 16, 2026

    @mblua
    OwnerAuthor

    Delivered in #3043, merged 2026-10-16T18:09:14Z. Exact tested head a821e3225308c1a346c40d17ec372372008dab25; merge/final clean main fb3cce95340c81fb6187fd9801278521f3817609. Frontend writes canonical configuration fields and distinguishes base command from appended arguments while retaining readers, strings, validation, lifecycle guards and final preview.

    All 25 PR checks/statuses passed, including all 14 current required contexts and legacy protection; regression run 38936412433 passed all 16 jobs. Local positive 465 tests/typecheck, outgoing-key mutation with seven expected failures, exact restoration 465 passed; affected Cargo compilation/format checks passed on the integrated head. Independent focused Grinch review passed; unchanged authored architecture approval remains applicable. The earlier run was cancelled before relevant main integration and is not a green result.

    Approved P03 v4 SHA256 A507042CA993C757DDBC6C5B76F4CAB71F12FFF8DC77A0D773B474C2B8BE5053; complete receipts and hashed evidence: room-shared i3018-command-fields/execution/P03/P03-delivered.md. No packaged build requested. #3018 remains open for #3022 documentation and the shared-policy receipt. Postmerge main workflows were still running at cleanup readback; their results are separate from this completed PR verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions