Skip to content

Document canonical fields and retain-legacy replacement policy #3022

Closed

Description

@mblua

Situation and intended change

Native phase P04 of #3018 (under E2432). Document delivered names in repository references and append the exact approved general field replacement rule to the project shared file guideline. The shared policy is a separate authorized artifact with before/after hash and diff receipt.

Class: mechanical. Source owner: ac-technical-writer-v5. Depends on: P03. Sequential fresh branch from main after dependency merge/ancestry.

Files

  • docs/reference/settings.md
  • docs/features/coding-agent-profiles.md

Additional shared artifact: D:/0_repos/AgentsCommander_iac/.ac/project-shared/Guidelines/File-user-surface-naming-convention.md; do not commit through product Git.

Mandatory acceptance

  1. Follow the exact approved phase, scope, ownership and green boundary; no new design decision.
  2. New field with content wins; otherwise legacy fallback. Identical frozen W predicate across runtimes; validate present values and preserve selected original text.
  3. Authorized updates write new fields only; retain current-source old key/value unchanged. No delete/update/synthesize old values, no write on read or new source authority.
  4. Preserve fixed base arguments/wrappers, parsing, launch text, metadata, references and current identity/hash inputs. No packaged build/install/release/version bump.
  5. Ship the phase proof/check receipts and exact-head applicable CI; PR closes only this child, never Clarify agent and profile command fields with new-first legacy fallback #3018. Writer must verify examples against landed behavior; policy covers declared types, valid false/zero/containers and string-specific fallback. Shared append requires separate path, before/after SHA256 and exact diff receipt.

Canonical approved specification

Root: D:/0_repos/AgentsCommander_iac/.ac/plans/3018-command-fields/plan-v8-command-fields.md
Plan-SHA256: D4B4C721BD29B0CBD9D2814109B15659A9E15B50BC425A0C9C23EAEFD1E0B410
Phase: D:/0_repos/AgentsCommander_iac/.ac/plans/3018-command-fields/p04-v2-docs-policy.md
Phase-SHA256: 5631C0485E40252F947D883B48486B126B89CA4C921C79C264FA11E9F36990D3
Five fresh approvals: D:/0_repos/AgentsCommander_iac/.ac/project-shared/parallel-room18-i3022/consensus/round11-v8-consensus.md (byte-verified copies of room19 originals). Standing user authorization, exact mapping receipt and cold gates govern execution; plans are immutable.

Verification

Run from the user-authorized room-18 repo-AgentsCommander; complete inventory/positive-negative proof and executor in the phase file.

git diff --check "$BASE"...HEAD
git diff "$BASE"...HEAD -- docs/reference/settings.md docs/features/coding-agent-profiles.md
rg -n 'baseCommand|additionalArguments|Additional arguments|Base command' docs/reference/settings.md docs/features/coding-agent-profiles.md

Parallel execution — user-authorized room 18

Room 19 assigns this existing P04 phase to room 18 in parallel with Epic #3047. Execute from D:/0_repos/AgentsCommander_iac/.ac/room-18-ac-dev-team-v5/repo-AgentsCommander, using branch docs/3022-docs-policy. This replaces only the historical room19 execution cwd; all relative file limits, phase identities, P03 dependency, acceptance criteria, independent cold verification and exact-head CI requirements remain. P01/#3019, P02/#3020 and P03/#3021 are CLOSED with merged PRs #3023/#3041/#3043; reverify ancestry against current main.

Authority and byte-verified five-party consensus copies: D:/0_repos/AgentsCommander_iac/.ac/project-shared/parallel-room18-i3022/execution-authority.md and its consensus/ directory. Canonical approved root is v8; canonical P04 remains v2, SHA256 5631C0485E40252F947D883B48486B126B89CA4C921C79C264FA11E9F36990D3. Return artifacts in that shared directory. Room19 owns runtime mapping and final Epic3018 closure; this phase PR closes only #3022.

Activity

  1. mblua commented on Oct 16, 2026

    @mblua
    OwnerAuthor

    I3022/P04 source baseline independently checked by room18 at 6f1ca43c06cb39a7caed941f1e640dc0bcde43de (tree d949fc202b43af056cc2ecd89727896719185f17).

    • src-tauri/src/config/settings.rs:23–63: frozen W content predicate, exact new-content > old-content > present-new > present-old selection, both-present string validation and original text.
    • src-tauri/src/config/settings.rs:75–88: known baseCommand/command and profile additionalArguments/command paired positions; :93 onward binds legacy preservation to the locked physical before source, not caller authority.
    • src/shared/ipc.ts:397–417: frontend exact W/both-string/selection counterpart; no runtime trim substitute.
    • src-tauri/src/config/settings.rs:31581–31677: landed strict malformed-field, W/FEFF and retained-source fixtures; these are source evidence to review, not newly executed tests.
    • src/sidebar/components/AgentPickerModal.tsx:1751–1752: combined launch display remains Command and composes base plus profile arguments; preserve this terminology.

    P01/#3019, P02/#3020 and P03/#3021 are CLOSED; PR3023/3041/3043 are MERGED, and each recorded merge is an ancestor of current origin/main (exit0). Issue #3022 OPEN, native parent #3018 verified. Local branch docs/3022-docs-policy validated; pristine BASE recorded before any edits. Shared policy has no existing field-replacement section at captured SHA256 AFA757718272933F857AD84BC187022D289097775C5525B8D12F1C46BE7DABB9.

    Execution records: D:/0_repos/AgentsCommander_iac/.ac/project-shared/parallel-room18-i3022/room18-consensus-receipt.json and room18-cold-and-base.md. Writer owns wording/examples; independent cold verification and all exact-head triggered/configured-required CI remain pending. No claim of test or delivery PASS.

  2. added a commit that references this issue on Oct 16, 2026
  3. mblua commented on Oct 16, 2026

    @mblua
    OwnerAuthor

    I3022 / E3018 P04 delivered

    PR #3055 MERGED at 2026-10-16T22:56:10Z; child #3022 CLOSED at 22:56:11Z. Closes only that child. Epic3018/E2432 closure and canonical phase mapping remain room19-owned.

    • Original BASE: 6f1ca43c06cb39a7caed941f1e640dc0bcde43de (preserved).
    • Tested/published head: 5103724de545591f90fd64e12bbdc80cbeb962fd; tree a41d9c6a829f92aed49cd7248cdaef05dd29668d.
    • Approved landing target: c6cc9d0cdabe36b6a7f2faf366358fb7d102d9a7; room19 classified its constructor/docs delta unrelated to P04 contracts/examples.
    • Merge/final local main: f24f55d596ed077ca348c4f4f7c75e439e53ac68, equals origin/main, upstream origin/main, index/tracked/untracked clean.
    • Feature branch absent locally and on server; stale local remote-tracking feature ref removed. Remaining remote refs only origin/main and origin/HEAD.

    Delivered behavior and scope

    The two approved documents now describe canonical baseCommand/additionalArguments names, strict both-present string validation, frozen content selection and original text, authoritative legacy key/value retention and unchanged launch/CLI behavior. No application code authored. JSON examples parsed and technical claims independently verified. Authored diff versus landing target is exactly docs/reference/settings.md and docs/features/coding-agent-profiles.md, and both final-main document blobs equal the reviewed/tested head. Predecessor P01/P02/P03 merge commits and tested H are verified ancestors of final main (four git merge-base --is-ancestor checks exit0).

    Verification and landing

    Independent cold RustGrinch and ArchitectGrinch PASS, followed by focused integration RustGrinch PASS. Their byte-bound reports and explicit source applicability are in this directory. Historical fixture executions remain attributed to their original heads; no local product tests/builds were repeated for docs.

    Exact-head regression run 38971365748 SUCCESS. All seven current-head workflows completed success; all26 current check/status results succeeded, including all14 configured-required contexts and matching integration IDs (GitHub Actions15368, Sonar12526). premerge-validated.json binds every required check run/app/head; premerge-pr.json, premerge-rules.json, premerge-check-runs.json and exact-head-green-receipt.json preserve actual snapshots. Protected admin merge used --match-head-commit on the exact green H. No CI failure bypass or duplicate unchanged rerun.

    User explicitly accepted the inherited release Markdown whitespace result; full originalBASE inventory and exit2 are retained in user-whitespace-disposition.md and integration receipts, authored target-to-head diff-check0. Room19's unrelated target disposition is recorded in room19-p04-target-scope-disposition.json and PR comment #3055 (comment). No unrelated release repair, originalBASE recapture or frozen-plan change.

    Separate shared-policy receipt

    Target: D:/0_repos/AgentsCommander_iac/.ac/project-shared/Guidelines/File-user-surface-naming-convention.md.
    Before:8756 bytes/SHA256 afa757718272933f857ad84bc187022d289097775c5525b8d12f1c46be7dabb9.
    After:10858 bytes/SHA256 91ea75420ad29c0b0407383bf3d0f5d2b032e8fedc6eb4a97ee3e83be1dce29c.
    Previous bytes remain an exact prefix; only the single exact P04 section was appended. Both independent reviewers verified retention/never-delete/no duplication/source authority. Final target bytes compare identical to shared-policy.after (cmp exit0); no further write. shared-policy.before/.after/.diff/shared-policy-receipt.json are separate, outside product Git.

    Completion

    Merged/closed receipts: merged-pr-receipt.json, closed-child-receipt.json; server feature absence: remote-feature-after-merge.txt (empty). All delegated concrete reports received and peer sessions closed. Final own-room dry-run/real purge succeeded, failed0, with no work in flight (final-purge-dry.log/final-purge-real.log). No build was requested; none produced or installed. No remaining P04 blocker or follow-up. Room19 receives this completed phase for combined E3018 verification and its own final closure decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions