Skip to content

refactor: sanitize 01 02 05 signals in src-tauri/src #3172

Closed
Closed
refactor: sanitize 01 02 05 signals in src-tauri/src#3172
Labels
refactor

Description

@mblua
mblua
opened on Oct 22, 2026

Situation

Measured on main @ 72aa89f27e319e0be6665c0f5f765a170fcd613b, from src-tauri/src:

Signal Measure Command Value
01 line length lines > 100 chars git ls-files '*.rs' | xargs awk 'length>100' | wc -l 2908
02 file size files > 1000 lines git ls-files '*.rs' | xargs wc -l | awk '$1>1000' 92
05 file structure mod.rs files find . -name mod.rs | wc -l 21
05 file structure files with #[test] outside tests.rs grep -rl '#\[test\]' --include=*.rs . | grep -v '/tests.rs$' | wc -l 185
05 file structure inline mod x { } blocks grep -rnE '^\s*(pub(\([a-z]+\))?\s+)?mod [a-z_]+\s*\{' --include=*.rs . | wc -l 268

208 target files ranked by size (largest: config/settings.rs 44554 lines, phone/mailbox.rs 41542).

Need

Reduce degradation signals 01-line-length, 02-file-size and 05-non-canonical-file-structure following the Rust sanitizing guidelines.

Intended change

Behavior-preserving fixes per recommendations 01-Rx, 02-Rx and 05-R1..R3, done in parallel by fixer rooms on one shared branch, one target file per room, largest first.

Scope

In: src-tauri/src/**/*.rs.
Out: behavior changes, new features, removing or weakening tests.

Acceptance criteria

  • Each signal measure, before -> after, never increases; target: decreases for every processed file.
  • cargo check --all-targets passes and required PR CI is green.
  • No behavior change; no test removed or weakened.

Files changed

  • src-tauri/.rust-cycles-baseline.json
  • src-tauri/module-arcs.txt
  • src-tauri/src/commands/config.rs
  • src-tauri/src/commands/config/agent_file_source.rs
  • src-tauri/src/commands/config/agent_update.rs
  • src-tauri/src/commands/config/coding_agent_catalog.rs
  • src-tauri/src/commands/config/coding_agent_profile.rs
  • src-tauri/src/commands/config/diagnostics.rs
  • src-tauri/src/commands/config/preferences.rs
  • src-tauri/src/commands/config/profile_selection.rs
  • src-tauri/src/commands/config/profile_selection/assignment.rs
  • src-tauri/src/commands/config/profile_selection/fingerprint.rs
  • src-tauri/src/commands/config/profile_selection/lock_removal.rs
  • src-tauri/src/commands/config/profile_selection/selection_default.rs
  • src-tauri/src/commands/config/profile_selection/target.rs
  • src-tauri/src/commands/config/profile_selection/wire.rs
  • src-tauri/src/commands/config/settings_snapshot.rs
  • src-tauri/src/commands/config/settings_update.rs
  • src-tauri/src/commands/config/tests.rs
  • src-tauri/src/commands/config/tests/agent_help_2133.rs
  • src-tauri/src/commands/config/tests/agent_order.rs
  • src-tauri/src/commands/config/tests/api_server.rs
  • src-tauri/src/commands/config/tests/coding_agent_install.rs
  • src-tauri/src/commands/config/tests/e2432_p02_source_api_tests.rs
  • src-tauri/src/commands/config/tests/hash_activation.rs
  • src-tauri/src/commands/config/tests/issue_3083_tests.rs
  • src-tauri/src/commands/config/tests/local_overlay_1737.rs
  • src-tauri/src/commands/config/tests/p02_wire_schema_tests.rs
  • src-tauri/src/commands/config/tests/placement.rs
  • src-tauri/src/commands/config/tests/profile_assignment.rs
  • src-tauri/src/commands/config/tests/project_reconcile.rs
  • src-tauri/src/commands/config/tests/room_idle_confirmation.rs
  • src-tauri/src/commands/config/tests/selection_api.rs
  • src-tauri/src/commands/config/tests/selection_api/barrier.rs
  • src-tauri/src/commands/config/tests/selection_api/bench.rs
  • src-tauri/src/commands/config/tests/selection_api/bench/drain.rs
  • src-tauri/src/commands/config/tests/selection_api/bench/enumeration.rs
  • src-tauri/src/commands/config/tests/selection_api/decision.rs
  • src-tauri/src/commands/config/tests/selection_api/default.rs
  • src-tauri/src/commands/config/tests/selection_api/error_code.rs
  • src-tauri/src/commands/config/tests/selection_api/preview.rs
  • src-tauri/src/commands/config/tests/selection_api/removal.rs
  • src-tauri/src/commands/config/tests/settings_draft.rs
  • src-tauri/src/commands/config/tests/settings_update.rs
  • src-tauri/src/commands/config/tests/snapshot.rs
  • src-tauri/src/commands/config/tests/web_server.rs
  • src-tauri/src/commands/config/web_server.rs
  • src-tauri/src/commands/session.rs
  • src-tauri/src/commands/session/co_managed_tests.rs
  • src-tauri/src/commands/session/coordinator_create_seam.rs
  • src-tauri/src/commands/session/reader_demand_tests.rs
  • src-tauri/src/commands/session/restart_reader_seam.rs
  • src-tauri/src/commands/session/restore_emit_seam.rs
  • src-tauri/src/commands/session/resume_args.rs
  • src-tauri/src/commands/session/resume_probe.rs
  • src-tauri/src/commands/session/room_raise_seam.rs
  • src-tauri/src/commands/session/seed_race_barriers.rs
  • src-tauri/src/commands/session/tests.rs
  • src-tauri/src/config/local_config_io.rs
  • src-tauri/src/config/settings.rs
  • src-tauri/src/config/settings/agent.rs
  • src-tauri/src/config/settings/agent/blocking_menu.rs
  • src-tauri/src/config/settings/agent/command.rs
  • src-tauri/src/config/settings/agent/file.rs
  • src-tauri/src/config/settings/agent/file/authority.rs
  • src-tauri/src/config/settings/agent/file/edit.rs
  • src-tauri/src/config/settings/agent/help.rs
  • src-tauri/src/config/settings/agent/instance.rs
  • src-tauri/src/config/settings/agent/instance/layer.rs
  • src-tauri/src/config/settings/agent/instance/overlay.rs
  • src-tauri/src/config/settings/agent/profile.rs
  • src-tauri/src/config/settings/agent/profile/identity.rs
  • src-tauri/src/config/settings/agent/profile/registered.rs
  • src-tauri/src/config/settings/field.rs
  • src-tauri/src/config/settings/load.rs
  • src-tauri/src/config/settings/owner.rs
  • src-tauri/src/config/settings/project_path.rs
  • src-tauri/src/config/settings/save.rs
  • src-tauri/src/config/settings/source.rs
  • src-tauri/src/config/settings/tests.rs
  • src-tauri/src/config/settings/tests/agent_help_2133.rs
  • src-tauri/src/config/settings/tests/blocking_menus_1905.rs
  • src-tauri/src/config/settings/tests/derived_agent_binding_projection_tests.rs
  • src-tauri/src/config/settings/tests/e2432_p02_closed_owner_tests.rs
  • src-tauri/src/config/settings/tests/e2432_p02_physical_file_tests.rs
  • src-tauri/src/config/settings/tests/e2432_profile_storage_tests.rs
  • src-tauri/src/config/settings/tests/e2992_p41_owner_tests.rs
  • src-tauri/src/config/settings/tests/fixtures/archived_project_paths_settings.json
  • src-tauri/src/config/settings/tests/fixtures/blocking_menus_extra_local.json
  • src-tauri/src/config/settings/tests/fixtures/blocking_menus_t11_local.json
  • src-tauri/src/config/settings/tests/fixtures/e2432_two_tool_agents.json
  • src-tauri/src/config/settings/tests/fixtures/independent_source_own_agent.json
  • src-tauri/src/config/settings/tests/fixtures/p03_member_inventory_c.json
  • src-tauri/src/config/settings/tests/fixtures/pristine_codex_array_settings.json
  • src-tauri/src/config/settings/tests/fixtures/s6_expected_non_project_settings.json
  • src-tauri/src/config/settings/tests/independent_source_tests.rs
  • src-tauri/src/config/settings/tests/issue_2348_main_window_placement.rs
  • src-tauri/src/config/settings/tests/issue_3047_schema.rs
  • src-tauri/src/config/settings/tests/local_overlay_1737.rs
  • src-tauri/src/config/settings/tests/p02_configuration_schema_tests.rs
  • src-tauri/src/config/settings/tests/p02_duplicate_row_tests.rs
  • src-tauri/src/config/settings/tests/p02_physical_schema_tests.rs
  • src-tauri/src/config/settings/tests/profile_identity_2450.rs
  • src-tauri/src/config/settings/tests/remote_blocking_menus_1925.rs
  • src-tauri/src/config/settings/tests/response_close_2850.rs
  • src-tauri/src/config/settings/tests/source_identity_tests.rs
  • src-tauri/src/config/settings/tests/source_inventory_projection_tests.rs
  • src-tauri/src/phone/mailbox.rs
  • src-tauri/src/phone/mailbox/diagnostics.rs
  • src-tauri/src/phone/mailbox/handoff.rs
  • src-tauri/src/phone/mailbox/internal_delivery.rs
  • src-tauri/src/phone/mailbox/notice.rs
  • src-tauri/src/phone/mailbox/outbox_auth.rs
  • src-tauri/src/phone/mailbox/peer_fallback.rs
  • src-tauri/src/phone/mailbox/poller.rs
  • src-tauri/src/phone/mailbox/pty_artifact.rs
  • src-tauri/src/phone/mailbox/pty_authority.rs
  • src-tauri/src/phone/mailbox/pty_claim.rs
  • src-tauri/src/phone/mailbox/pty_dispatch.rs
  • src-tauri/src/phone/mailbox/pty_validation.rs
  • src-tauri/src/phone/mailbox/request_polling.rs
  • src-tauri/src/phone/mailbox/response_source.rs
  • src-tauri/src/phone/mailbox/self_handoff.rs
  • src-tauri/src/phone/mailbox/self_switch.rs
  • src-tauri/src/phone/mailbox/session_lookup.rs
  • src-tauri/src/phone/mailbox/session_request.rs
  • src-tauri/src/phone/mailbox/settle.rs
  • src-tauri/src/phone/mailbox/tests.rs
  • src-tauri/src/phone/mailbox/wake_delivery.rs
  • src-tauri/src/phone/mailbox/wake_injection.rs
  • src-tauri/src/phone/mailbox/wake_workers.rs
  • src-tauri/src/session/selection.rs
  • src-tauri/tests/c4_state_key_census.rs
  • src-tauri/tests/pty_writer_inventory.rs
  • src-tauri/tests/spawn_search_path_inventory.rs

Census pending

Census updated at af30d0d (room-32). Files added/moved/deleted since then:

  • (none)

Activity

  1. mblua
    added
    refactor
    on Oct 22, 2026
  2. mblua
    added 20 commits that reference this issue on Oct 22, 2026

    refactor(sanitize): 05-R2 move mailbox tests to mailbox/tests.rs (#3172)

    0b2d503

    refactor(sanitize): 05-R2/R3 move settings test modules to settings/t…

    1f77c8f

    refactor(sanitize): 05-R2 update settings test-path pins and ids (#3172)

    142f3da

    refactor(sanitize): 05-R2 repin census and test-debt ids after mailbo…

    5d5917f

    refactor(sanitize): 01 wrap mailbox lines over 100 chars (#3172)

    cc0b768

    refactor(sanitize): 01-R1/R2/R3 keep settings lines within 100 chars (#…

    0caa1d6

    refactor(sanitize): 05-R2/R3 move commands/config tests to config/tes…

    dfa6dce

    refactor(sanitize): 01-R1/R2/R3 keep commands/config lines within 100…

    76b59b3

    refactor(sanitize): 05-R2/R3 move session test and seam modules to co…

    ec82fb8

    refactor(sanitize): 05-R2 skip test-only files in lifecycle ownership…

    203ee7e

    refactor(sanitize): 01-R1/R2/R3 keep commands/session lines within 10…

    2a9a6dd

    refactor(sanitize): 02 split settings into agent/source/field/load/pr…

    3390e58

    refactor(sanitize): 02-R2 split commands/config into noun submodules (#…

    ad7aa1d

    refactor(sanitize): 02-R2 split commands/config/profile_selection by …

    233ca76

    refactor(sanitize): 02-R2 split mailbox into submodules (#3172)

    cf8a147

    refactor(sanitize): 02-R2 repoint pty writer inventory to mailbox sub…

    79cc8cb

    refactor(sanitize): 05-C6 split commands/config tests by noun (#3172)

    33bd639

    refactor(sanitize): 02-R2 split session resume args and probe into co…

    dd3e148

    chore(sanitize): regenerate module-arcs after session split (#3172)

    bb4c565

    refactor(sanitize): 02 split settings/agent into command/profile/inst…

    022a421
  3. mblua
    added 3 commits that reference this issue on Oct 22, 2026

    refactor(sanitize): 05-R2 skip test-only files in local config writer…

    77ea63a

    test(sanitize): update state-key census and spawn inventory for moved…

    af30d0d

    fix(sanitize): 05 gate accepts use super::* in tests/ folder files pe…

    dde98bc

  4. mblua commented on Oct 22, 2026

    @mblua
    mblua
    on Oct 22, 2026
    OwnerAuthor

    Batch 1 closed — PR #3175

    • Branch head: dde98bc (includes main @ 80722c8). PR opened before full CI; the next batch branches from this head and fixes whatever fails here.
    • All 4 targets are partial and back to pending in file-token/targets.json, with a note of what is left and per-signal status (01/02/05) measured at af30d0d.
    • Known gate failures vs main: file_size 14, line_length 1, file_layout 23, tauri_edge 24, global_state 11, process_env 1 (details in PR refactor: sanitize 01 02 05 signals in src-tauri/src, batch 1 (refs #3172) #3175).
    • Measure fix: signal 05 "#[test] outside tests.rs" now also excludes tests/ (rule C6) in DegradationSymptoms/05. With it: 185 -> 181.
    • Census (c4_state_key_census.rs, spawn_search_path_inventory.rs) current at af30d0d.
    • Known flaky tests in commands::session (~1 in 4 runs, pre-existing), reported by room-32.

  5. mblua commented on Oct 22, 2026

    @mblua
    mblua
    on Oct 22, 2026
    OwnerAuthor

    Next batch: #3176, branch refactor/3176-sanitize-rust-codebase from dde98bc.

  6. mblua commented on Oct 23, 2026

    @mblua
    mblua
    on Oct 23, 2026
    OwnerAuthor

    Batch 1 is fully in main via #3179 (merge commit e939e9c). Work continues in #3176.

  7. mblua
    closed this as completedon Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactor

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions