Repository navigation
Conversation
…, refs #1606 Two changes landed today that the docs did not reflect. #1589 shipped agentscommander-X.Y.Z-windows-x86_64-portable.zip, but quickstart still offered "the portable agentscommander.exe", an asset that has never existed. A reader following that downloads the raw agentscommander-windows-x86_64.exe instead, whose name parses as instance suffix "64" and silently changes their config directory, mutex, and ports. README gestured at "portable assets" without naming one. #1592 replaced the silent second-instance exit with a message that explains the collision and points at the rename. PORTABLE.txt ships inside the zip specifically to explain that scenario and still described the old behavior. Deliberately left alone, so they get corrected once rather than twice: - README "copy the .exe to any drive and it carries its own config", true only where the destination is writable, which #1577 fixes. - portable-instances "AC keeps no global state outside that directory", not true while the WebView2 user-data folder defaults to %LOCALAPPDATA%, which #1590 fixes. macOS and Linux portability wording is untouched for the same reason: each needs #1577 plus a platform-specific bundle-aware resolver branch. Claude-Session: https://claude.ai/code/session_01HydthWuftnNBoYzqHZTNm8
|
Owner
Author
|
Heads-up: the required checks on The
This branch still runs the old workflow, so those checks never report here and the PR cannot merge as it is. What to do when this PR is ready to land: wait until PR #3185 is merged, then bring this branch up to date with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #1606.
Documentation catch-up for two changes that landed today. No behavior, workflow, or script change.
What was wrong
The portable download had no name. #1589 shipped
agentscommander-X.Y.Z-windows-x86_64-portable.zip, gated so a release without it stays a draft. Butdocs/quickstart.mdstill offered "the portableagentscommander.exe", which has never been a published asset. A reader following that instruction downloads the rawagentscommander-windows-x86_64.exeinstead, and that name parses as instance suffix64, silently giving them.agentscommander-windows-x86_64\, anAC [64]badge, a non-default mutex, and ports 9886/9906 instead of 9877/9887. Naming the real asset is what prevents that.The second-instance behavior changed. #1592 replaced the silent
exit(0)with a message explaining the collision and pointing at the rename.packaging/windows/PORTABLE.txtships inside the zip specifically to explain that scenario and still described the old behavior.Deliberately not fixed here
Two claims in these same files are inaccurate today. Both are fixed by work in flight, so correcting them now would mean writing the text twice:
README.md:63"copy the.exeto any drive and it carries its own config"docs/features/portable-instances.md:85"AC keeps no global state outside that directory"%LOCALAPPDATA%\dev.agentscommander.app\because no builder setsdata_directory. #1590 confines it.macOS and Linux portability wording is untouched for the same reason: each needs #1577 plus a platform-specific bundle-aware resolver branch (#1594 for macOS; the AppImage case is not filed yet). Until those land, an AppImage or a
.appis a per-user install rather than a portable one, and the docs should not claim otherwise in either direction.Verification
README.mdordocs/still offers a portable download by a name that is not a published release asset.bundle-validationruns on this PR because it touchespackaging/windows/**, so the rewordedPORTABLE.txtis re-packed and re-smoked against a real built binary.https://claude.ai/code/session_01HydthWuftnNBoYzqHZTNm8