Skip to content

feat(frontend): mirror the Muse Code preset and pin fresh/resume intent (#1861) - #1918

Open
mblua wants to merge 1 commit into
mainfrom
feature/1861-muse-frontend-catalog
Open

mblua wants to merge 1 commit into
mainfrom
feature/1861-muse-frontend-catalog

Conversation

@mblua

@mblua mblua commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Summary

Phase 3 of epic #1854. Mirrors the landed Muse Code catalog row as the eighth and last entry of the frontend fallback (FALLBACK_CODING_AGENTS), exactly matching the embedded Rust catalog from #1860, and pins the existing provider-neutral fresh/resume intent that the frontend already sends so the #1873 backend contract is exercised end to end.

Production change is one data constant plus two comments. root-agent-action.ts executable logic, ProjectPanel.tsx, the updater, types.ts, dependencies and module boundaries are untouched.

Files (exactly the six planned)

src/shared/agent-presets.ts, src/shared/agent-presets.test.ts, src/sidebar/agent-update-status.test.ts, src/sidebar/components/ProjectPanel.reopen-resume.test.tsx, src/sidebar/components/root-agent-action.ts (comment only), src/sidebar/components/root-agent-action.test.ts.

Tests

  • Eight presets in order (claude, codex, hermes, cursor, pi, opencode, antigravity, muse); Muse row pinned with toStrictEqual; instructionsFilename/configSeed absent before and after definitionToSeed; six update commands exact; Cursor and Muse the only empty-update defaults; pi-alt view length 7.
  • ProjectPanel: closed marker → skipAutoResume:false, no marker → null, with agentId: "muse".
  • Root: no record → create; live record → restart with skipAutoResume strictly omitted (not.toHaveProperty); dormant → own skipAutoResume:false.
  • Lead-owned frozen executor (independent base measurement + candidate): Vitest 4 files / 35 tests twice, check:frontend-dependencies byte-identical to base (386 modules, 0 errors), typecheck, build, scope, protected bytes, empty porcelain: PASS. Grinch review PASS with nine hand-built mutants killed.

Process note

Landed by the user decision recorded on #1873: the frozen plan's attestation message chain is replaced by the lead verification comments on #1861 and the required CI at this PR head. No app behaviour changes; the backend owns every provider's effective argv.

Closes #1861
Refs #1854

https://claude.ai/code/session_01FhU3mscWfoKwwBTnRz65xk

…nt (#1861)

Append the beta Muse Code row as the eighth and last fallback catalog
entry so the frontend copy matches the backend embedded default landed by
#1860, and pin the settled provider-neutral fresh/resume intent in the
existing ProjectPanel and Root action consumers: a closed marker sends
skipAutoResume:false, no marker sends null, a live Root omits the key
(fresh replacement) and a dormant Root sends false.

Only one data constant, one explanatory comment and four test files
change. No type, UI, runtime, IPC, persistence, updater or dependency
change; Muse argv and resume remain backend-owned (#1873).

Refs #1861, #1854

Claude-Session: https://claude.ai/code/session_01WzSJFZTuHMDotLSGQtBwgw
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mblua

mblua commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

Heads-up: the required checks on main changed (#3184, PR #3185).

The main ruleset now requires these checks instead of the old names:

  • rust-regression is now rust-regression-windows
  • windows-release-cli-smoke is now release-cli-smoke-windows
  • new: issue-1850-release-windows, issue-1850-release-linux, issue-1850-release-macos and rust-slow-test-windows

This branch still runs the old workflow, so those checks never report here and the PR cannot merge as it is.

What to do when this PR is ready to land: wait until PR #3185 is merged, then bring this branch up to date with main (the ruleset already requires that). The new workflow comes with it and reports the new check names. Resolve any conflict in .github/workflows/pr-regression-gates.yml in favour of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mirror Muse Code in the frontend catalog

1 participant