Repository navigation
Conversation
Frozen plan, byte-unchanged, SHA-256 803b56db0236fd43ec5e9cb0928304c1ab5474fc259724396c32c1055cd3144f.
resolve_local_dir(crate::config::config_dir()) replaces the legacy adjacent-directory derivation; a non-Unicode root fails before permit reservation, pending row, or clock mutation. Container transport keeps an empty extra_env. Gates: fmt, check --all-targets, clippy -D warnings, focused pty::credentials and T12 tests pass. Full lib suite: 135 pre-existing failures, identical to base 5203c4e. Windows-only T5a/T8 await Windows CI on the PR head.
|
Owner
Author
|
Heads-up: the required checks on The
This branch still runs the old workflow, so those checks never report here and the PR cannot merge as it is. What to do when this PR is ready to land: wait until PR #3185 is merged, then bring this branch up to date with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1115
Change
Host local PTY agent sessions now export
AGENTSCOMMANDER_LOCAL_DIRfrom the already-resolvedconfig::config_dir()(#1850) instead of re-deriving<exe dir>/.<stem>.pty/credentials.rs:resolve_local_dirtakes the resolved root;Some→ exact path, lossless or actionable error;None→ legacy adjacent fallback with an injected warning, lossless (OsStr stem/parent); verbatim prefixes viapath_utils::normalize_windows_verbatim_path. Depends only on std + path_utils (AC6).commands/session.rs: resolution runs for agent + LocalProcess sessions before the launch permit is reserved, so a failure leaves no residue; containers unchanged (AC5).Plan & review
plans/1115-export-resolved-local-root.md, Plan-SHA256803B56DB0236FD43EC5E9CB0928304C1AB5474FC259724396C32C1055CD3144F; architect/dev/grinch consensus after 4 rounds; user-approved.987c6625with mutation controls (lossy conversion, missing warning,unwrap_or_defaultfor?, resolve after permit, dropped agent gate,Noneresolver, silenced warn sink — all caught).d57a4c4b), Grinch focused merge review PASS.-D warnings, credentials 14/14, T12; Windowsrust-regressioncovers T5a/T8.Follow-up (pre-existing permit leaks, out of scope): #2093.