Skip to content

test(2932): register task snapshots in sidebar toast fixtures - #2933

Merged
mblua merged 2 commits into
mainfrom
fix/2932-sidebar-fake-task-snapshot
Oct 7, 2026
Merged

mblua merged 2 commits into
mainfrom
fix/2932-sidebar-fake-task-snapshot

Conversation

@mblua

@mblua mblua commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Sidebar menu, restart and wake toast tests fail when their fake transport rejects the required task snapshot read, adding an unrelated error toast. Register valid typed snapshots in three local fixtures so the existing behavior assertions execute unchanged.

Closes #2932. Unblocks separate documentation PR #2878.

The user authorized merge to origin/main after successful validation. The earlier prepare-only hold is lifted. No runtime, shared harness, assertions, classifier, dependency, version or workflow changes in the fix.

Current reviewed head: c91d264, integrating current main d720ea2. Independent focused integration/code/proof review PASS; original three-file patch byte-identical before/after integration, assertions preserved.

Local integrated proof: 170 focused tests pass, including all 27 original assertions and affected context-menu/store tests. Full suite 3,821 assertions across269 files pass, zero failed/skipped/todo. Typecheck, dependencies, arcs, cycles, dup:changed and diff checks pass.

Raw after/full tests retain exactly one known #480 WebSocket rejection, accepted by the unchanged classifier. These are not strict clean raw runs.

Earlier head3ecc6716 completed full remote CI successfully on attempt2 after two Rust capture tests passed on retry, with no source changes. That result does not certify this new head. Full-tier CI requested on c91d264 through ci:full; verify exact revision and actual checkout before merge. No build/publication/deployment requested.

@mblua mblua added the ci:full Run the full PR regression gates on this PR label Oct 7, 2026
@mblua

mblua commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Stale-base triage after the four-commit main advance:

Reviewed head: 3ecc671; main: adf30ec. Incoming commits belong to documentation PR #2929.

Incoming changed paths are docs/agents/teams-and-workgroups.md, docs/concepts.md and docs/reference/cli.md only. No overlap with the three test fixtures, executable imports/dependents, manifests/lockfiles, build configuration or .github workflows. Classified unrelated documentation delta.

No branch update or fresh CI requested solely for this delta. Existing CI evidence, when available, must still identify the exact reviewed head and actual checkout revision. No CI success inferred from the behind notice. Merge HOLD and required approvals/protections remain in effect.

@mblua

mblua commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Completed full-tier CI run37552386401 on head3ecc6716f116fe6bafc3b29021a4a1b345bf65e6: FAILURE.
Run: https://github.com/mblua/AgentsCommander/actions/runs/37552386401

frontend-regression SUCCESS: actual checkout23b465019fd4efd47f1022e1cd199017dac694f6 is the merge-ref of head3ecc6716 into base0e2c7197ae6141ae1b589874a0cb44a60d731b6c. Node22;269 files and3807 assertions pass. Existing #480 guard tolerates exactly one known WebSocket rejection; no strict raw-green claim. This verifies the frontend correction in actual CI.

Remaining required failure is Windows rust-regression:5978passed/2failed/26ignored. Both fail with committed: PreconditionsStale:

  • capture::state::tests::the_authoritative_epoch_is_the_persisted_one_not_the_records_field (state.rs:1691)
  • capture::state::tests::returning_to_a_file_recovers_its_watermark_and_epoch (state.rs:1080)

Linux/macOS Rust, four terminal snapshot platforms and release CLI smoke all succeed in the completed full run. The earlier run37552385156 was cancelled and superseded; not the result used here.

Exact-name/all-state and PreconditionsStale/open issue searches found no matching tracking issue; search is not exhaustive. No causal diagnosis, base reproduction or flake claim for these Rust failures yet. No Rust changes, rerun, bypass or merge performed.
Merge HOLD and external review requirement remain. Incoming main delta previously documented is documentation-only and did not affect this checkout's frontend proof.

@mblua

mblua commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

User-requested rerun of failed jobs completed successfully. Run37552386401 attempt2 on unchanged head3ecc6716f116fe6bafc3b29021a4a1b345bf65e6:
https://github.com/mblua/AgentsCommander/actions/runs/37552386401/attempts/2
All jobs in the completed regression run are SUCCESS. Windows rust-regression job112598324269 confirms both previously failing tests now pass:

  • capture::state::tests::returning_to_a_file_recovers_its_watermark_and_epoch ... ok
  • capture::state::tests::the_authoritative_epoch_is_the_persisted_one_not_the_records_field ... ok
    No source changes between attempts. The observed fail-then-pass is consistent with an intermittent failure; root cause remains undiagnosed. No additional Rust fix or bypass performed.
    CI blockage is cleared for this head. Merge HOLD remains; GitHub still reports REVIEW_REQUIRED and reviews are empty. PR and issue stay open. No GTM contact per user instruction.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

@mblua

mblua commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Landing verification: all reported PR checks succeeded for exact head c91d264; regression run 37621216348 completed successfully. New main delta d720ea2..938dfc2 is documentation-only: four Markdown files, five insertions/five deletions, no source, dependencies, build inputs or workflow changes. Reuse exact-head green CI per landing policy. Direct user authorization releases the earlier merge hold.

@mblua
mblua merged commit 7217f6a into main Oct 7, 2026
24 checks passed
@mblua
mblua deleted the fix/2932-sidebar-fake-task-snapshot branch October 7, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:full Run the full PR regression gates on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix sidebar fake task snapshot handlers blocking frontend regression CI

1 participant