Skip to content

chore(profiles): preserve pair identity metadata in TypeScript (refs #3052) - #3089

Merged
mblua merged 3 commits into
mainfrom
chore/3052-profile-pair-types
Oct 18, 2026
Merged

mblua merged 3 commits into
mainfrom
chore/3052-profile-pair-types

Conversation

@mblua

@mblua mblua commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Profile cells now expose optional backend-derived id_hash metadata in TypeScript. Existing transport fixtures verify literal preservation through configuration reads and saves with legacy/canonical arguments and with/without the field. The legacy agent hash remains distinct.

Only src/shared/types.ts and src/shared/ipc.transport.test.ts differ from integrated main ea5d4ab. The original P03 contribution is preserved, including the transport test blob. The types file combines the original metadata hunks with incoming main settings; all other tracked blobs and modes match that main target. This completes P03 of #3047.

Validation on 51163de (tree 8177e6884cf96f3fe438378cabb0ee592b11edc1):

  • Shipper: typecheck, 199 IPC transport tests, frontend build, frontend dependency check, arc/cycle checks, and four Rust structural targets (25/5/1/3 passed). All seven commands exit 0, no skipped/ignored tests; 139 physical source/tool/config/lock bindings unchanged before/after.
  • Independent Grinch: CODE_AND_PROOF_PASS for the integrated source and new runtime evidence. Complete 1198-path union, preserved P03 hunks and incoming main changes, unchanged SCC member sets and byte-identical module arcs verified.
  • The earlier CI on 14bd1be was cancelled to integrate incoming main changes. Its results are historical. New exact-head CI must pass before merge.
  • Local Node26/npm11.19 differ from CI Node22/npm11.6.2. Original-BASE whitespace findings are only inherited Markdown hard breaks in the release plan; authored delta against integrated main passes diff-check.

The parent remains open until all phases land and final integrated validation completes.

Closes #3052

@sonarqubecloud

Copy link
Copy Markdown

@mblua

mblua commented Oct 18, 2026

Copy link
Copy Markdown
Owner Author

Step 9.5: incoming main delta classified UNRELATED_NO_UPDATE by ac-dev-rust-grinch-v5 and verified by Lead.

Validated head: 51163de. Integrated main: ea5d4ab. Current main: e86896d. Incoming path: src-tauri/src/commands/entity_creation.rs only (team-source-identity-import, PR #3082). No overlap with the two P03 paths, no import/module arc change, and no settings/ProfileCellConfig/id_hash/codingAgentProfiles/additionalArguments contract change. Optional team IPC parameters are outside the tested P03 transport commands. No locks, configs, workflows, scripts or frontend build inputs changed; P03 does not alter this Rust file or its main-owned tests/guards. No material combined impact found.

Reusing exact-head green CI, without branch update or CI rerun, per git-landing-flow / workflow Step 9.5. Regression run39080469247 attempt1 succeeded: Windows library6376 passed/0 failed/26 ignored, Linux Clippy and remaining executed jobs passed. Five triggered workflows succeeded;12 successful CheckRuns plus external success. Seven jobs correctly not applicable by authoritative full=false; all14 required context/app identities reconciled. Local Shipper7commands and independent code/proof review passed on exact51163de.

Review artifact: D:/0_repos/AgentsCommander_iac/.ac/room-19-ac-dev-team-v5/room-shared/e2432-id-hash/profile-correction/execution/P03/P03-GRINCH-e868-delta-triage.md; SHA256 ED348511E2CCB1D88167A6D398DF1825606702340086DBD0124D84697265F62D. CI gate: D:/0_repos/AgentsCommander_iac/.ac/room-19-ac-dev-team-v5/room-shared/e2432-id-hash/profile-correction/execution/P03/P03-ci-51163-verified-gate.json. Final integrated validation remains pending after merge; Epic #3047 stays open until it passes.

@mblua
mblua merged commit a4c18bf into main Oct 18, 2026
20 checks passed
@mblua
mblua deleted the chore/3052-profile-pair-types branch October 18, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I3047 P03: Mirror profile-pair hash metadata in client transport

1 participant