Repository navigation
refactor: sanitize Rust codebase, batch 12 (refs #3231) - #3232
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #3231
Continues batch 11 (#3227, PR #3230, merged as
14cd839).Batch 12 of the Rust sanitizing campaign. It implements the first step of the batch 10 design proposal G06 (symptom 06, infrastructure outside the edge) and removes two stale gate 09 allowlist entries. No security, authority, ordering,
cfg, IPC or public API change. It does not touch files reserved by #3198, #3199 or the cut issues.Changes
928c503): newpub(crate)modulesrc-tauri/src/repos.rswith the pure rulesderive_repo_nameandstrip_userinfo, moved literally fromcommands/repos.rs.commands::reposkeepsderive_repo_namethrough an internal re-export. The two URL tests moved torepos/tests.rswithout changing asserts, and new tests coverderive_repo_name.reposdepends only onstd.72274c4): the gate 06 had a real gap: a new core file using Tauri only undercfg(test)passed. The gate now checks test tokens of new files with the same alias resolver. New regression fixtures cover direct use, aliases,cfg(test)and innercfg. Production counters do not change.5613015): removed the stalelaunch_filesentries forconfig/agency_cache.rs(itsCommandsites moved toprocess.rsin batch 11) andconfig/agency_cache/git.rs(the site exists but is already in the base, so the entry accepted nothing). No other entry changed.4ceeb6c):c4_state_key_census1281 → 1283 (repos.rs,repos/tests.rs).spawn_search_path_inventoryunchanged: the new files launch nothing.Measurements (
0176550→4ceeb6c)commands/reposcfg(test))Verification (room-35, Windows,
4ceeb6c)cargo fmt --check,cargo clippy --all-targets -- -D warnings: pass.cargo test --lib: 6604 passed, 0 failed, 30 ignored.cargo test --test '*' --no-fail-fast: 321 passed, 0 failed, 6 ignored (30 binaries, census included).sanitizing:*gates (--base-ref 0176550),sanitizing:self(69/0/0),test:debt,check:arcs(2949),check:cycles(0 new),check:served-paths,cog:scan,cog:baseline: pass.Known red gates
None known.
Known warnings (not blocking, deferred)
concat!WARN incheck:served-paths, same as batch 11.Rooms
Files modified
sanitizing.allowlist.jsonscripts/sanitizing_tauri_edge.mjsscripts/sanitizing_tests.mjssrc-tauri/module-arcs.txtsrc-tauri/src/commands/repos.rssrc-tauri/src/commands/repos/tests.rssrc-tauri/src/lib.rssrc-tauri/src/repos.rssrc-tauri/src/repos/tests.rssrc-tauri/tests/c4_state_key_census.rs