Repository navigation
fix(deps): pin node-pty to its patched version for release archives - #14
Merged
Merged
Conversation
Release archives install runtime packages without the lockfile, so the ^1.2.0-beta.15 range resolved to a newer beta and pnpm rejected the unused node-pty patch. Same approach as upstream 22840ab (pingdotgg#23798). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream fix 22840ab943 — pin all patched package versions (pingdotgg/t3code#23798)
Existing systems changed
pnpm-workspace.yaml):node-ptyis pinned to1.2.0-beta.15, the version its patch targets. The lockfile keeps the same resolved version; only the importer specifier changes.How the systems interact
scripts/build-cli-archive.ts): stages the server's runtime externals into a freshpackage.jsonand runsvp install --prodwithout the lockfile, copying the workspaceoverridesand the patches that apply.^1.2.0-beta.15to the newest beta (1.2.0-beta.18, now past pnpm's release-age window), so thenode-pty@1.2.0-beta.15patch went unused and pnpm stopped withERR_PNPM_UNUSED_PATCH. With the override the stage installs the same patchednode-ptyas the running release.Only
node-ptyis pinned (upstream pins every patched package): it is the only patched runtime external with a version range;@ff-labs/fff-nodeis already exact.Verifiable outcome
Release built from this branch's merge: see the fork's releases page
🤖 Generated with Claude Code