Skip to content

feat: adding slides configuration in carousel - #2245

Open
DiljohnSingh wants to merge 4 commits into
mendix:mainfrom
DiljohnSingh:feat/Carousel-slides-props
Open

feat: adding slides configuration in carousel#2245
DiljohnSingh wants to merge 4 commits into
mendix:mainfrom
DiljohnSingh:feat/Carousel-slides-props

Conversation

@DiljohnSingh

@DiljohnSingh DiljohnSingh commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Pull request type

New feature (non-breaking change which adds functionality)

Description

  • Currently slidesPerView is hardcoded to be 1 and not a configurable prop.
  • Some of the siemens projects using Mendix had to create custom widgets to display more than one slide into view.
  • Adding two new slide configs/props. (slidesPerView & slidesPerGroup).
  • Default value is still set to 1 to follow default behavior.
  • Added useMemo for carouselItems.

What should be covered while testing?

  • You should see two new configs(slidesPerView & slidesPerGroup).
  • Play around with configs to see the changes into slides.

@DiljohnSingh
DiljohnSingh requested a review from a team as a code owner June 3, 2026 08:44
@DiljohnSingh DiljohnSingh changed the title feat: adding slides configuration feat: adding slides configuration in carousel Jun 3, 2026
@DiljohnSingh
DiljohnSingh force-pushed the feat/Carousel-slides-props branch from b270749 to 66f2472 Compare June 22, 2026 08:27
@gjulivan
gjulivan force-pushed the feat/Carousel-slides-props branch 2 times, most recently from ea0ca1f to 656ba52 Compare September 9, 2026 14:41
@gjulivan gjulivan mentioned this pull request Sep 9, 2026
Closed
@gjulivan

gjulivan commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

added commit:

  • fix carousel design preview
  • update swiper dependencies

https://mendix.atlassian.net/browse/WC-3506

gjulivan
gjulivan previously approved these changes Sep 9, 2026
View reviewed changes
@gjulivan
gjulivan force-pushed the feat/Carousel-slides-props branch from 2cbb24e to 488e25e Compare September 10, 2026 13:00
@gjulivan
gjulivan force-pushed the feat/Carousel-slides-props branch from 488e25e to 4b062e2 Compare September 10, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjulivan gjulivan gjulivan approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

carousel-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DiljohnSingh @gjulivan