Repository navigation
fix(errors): preserve API error details - #156
Open
Diego Barajas (barajas-d) wants to merge 5 commits into
Open
Diego Barajas (barajas-d) wants to merge 5 commits into
Diego Barajas (barajas-d) wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve useful error details when an API response has no top-level
message, such as an Order API 402 body containingerrorsanddata.Changes
messageanderrorwith the API message, or the complete serialized body when it is absent.MPResponse.error_messagefor unsuccessful responses.exception.response.Compatibility
exception.errorpreviously held the APIerrorcode; it now contains the message or serialized body. Consumers needing the original code can readexception.response["error"]. The fallback can include all fields in the API response.Validation