Fix thread issues added upstream - #56
Open
David-LP99 wants to merge 1 commit into
Open
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to deal with two changes involving threads from upstream.
The base64 encode and decode functionality added in ros2#533 for configuring binary data in YAML files is not needed in micro-ROS. It's only reference at the moment comes from
rcl_yaml_param_parser, which is also disabled in micro-ROS.In ros2#579, it was also added a dependency on
pthreads, which is not used anywere else in micro-ROS and should be gated onRCUTILS_NO_THREAD_SUPPORT.Main changes
base64.cfrom compiling inmicro-ROS/rcutilsThreadsis now linked conditionally onRCUTILS_NO_THREAD_SUPPORT