Skip to content

Make the parameter help shortcut translatable #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microbit-matt-hillsdon merged 3 commits into from
Nov 4, 2026
Merged

Make the parameter help shortcut translatable #1393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb383e6
Make the parameter help shortcut translatable
helloigig Nov 4, 2026
a2886bc
Remove parameter help shortcut translation test
helloigig Nov 4, 2026
6b460ec
Merge branch 'main' into translate-parameter-help-shortcut
microbit-matt-hillsdon Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lang/ui.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,14 @@
"defaultMessage": "Manual ({shortcut})",
"description": "Parameter help setting for when the user must press a key combination to open the parameter documentation"
},
"parameter-help-shortcut": {
"defaultMessage": "Ctrl+Shift+Space",
"description": "Keyboard shortcut that opens parameter help on Windows, Linux and ChromeOS. Shown in brackets after the Manual parameter help setting. Use the key names printed on keyboards in your language."
},
"parameter-help-shortcut-mac": {
"defaultMessage": "Cmd+Shift+Space",
"description": "Keyboard shortcut that opens parameter help on a Mac. Shown in brackets after the Manual parameter help setting. Use the key names printed on Mac keyboards in your language."
},
"permanently-delete": {
"defaultMessage": "Permanently delete {filename}?",
"description": "Confirmation question to permanently delete file"
Expand Down
6 changes: 5 additions & 1 deletion src/settings/SettingsArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ const SettingsArea = () => {
"parameter-help",
intl,
{
shortcut: (isMac ? "Cmd" : "Ctrl") + "+Shift+Space",
shortcut: intl.formatMessage({
id: isMac
? "parameter-help-shortcut-mac"
: "parameter-help-shortcut",
}),
}
),
};
Expand Down
Loading