Repository navigation
[DRAFT - DO NOT MERGE] Acknowledge simulator serial output for flow control - #1404
Closed
microbit-robert wants to merge 1 commit into
Closed
microbit-robert wants to merge 1 commit into
microbit-robert wants to merge 1 commit into
Conversation
Opt in to the simulator's serial flow control via config and acknowledge serial output from xterm's write callback. The simulator then sends output as fast as the terminal can write it, rather than at the device's baud rate, and a busy program can't get ahead of the terminal. Output discarded while the terminal is unmounted is still acknowledged so the simulator doesn't wait. Temporarily points the simulator at the serial-output-flow-control review build for testing. Remove before merge. Refs #1242
|
Preview build will be at |
microbit-robert
commented
Nov 9, 2026
Comment on lines
+49
to
+50
| // TODO: remove before merge, once the simulator is released. | ||
| const branch: string | undefined = "serial-output-flow-control"; |
Collaborator
Author
There was a problem hiding this comment.
Flagging TODO
Collaborator
Author
|
@microbit-matt-hillsdon Can be reviewed, but not merged until the TODO is actioned. Also helpful to wait until the simulator PRs are in, but in reality, the worst case seems to be that we send extra things to the simulator that it ignores. |
Collaborator
Author
|
Closing in favour of microbit-foundation/micropython-microbit-v2-simulator#138 in isolation which works well in testing and no API change is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt in to the simulator's serial flow control via config and acknowledge serial output from xterm's write callback. The simulator then sends output as fast as the terminal can write it, rather than at the device's baud rate, and a busy program can't get ahead of the terminal. Output discarded while the terminal is unmounted is still acknowledged so the simulator doesn't wait.
Temporarily points the simulator at the serial-output-flow-control review build for testing. Remove before merge.
Refs #1242