Repository navigation
Update TypeScript to v6 - #1407
Merged
Merged
Conversation
Drop baseUrl from tsconfig.json: v6 deprecates it (TS5101) and the styled-system path mapping is already relative to the tsconfig. Typecheck tsconfig.node.json (vite.config.ts, panda.config.ts) as part of `npm run typecheck`. It was not checked by any script and had drifted: - vitest/config no longer exports UserConfig; use ViteUserConfig. - process.env.BASE_URL is possibly undefined now that strict is the default. A staged build without BASE_URL previously threw at config load and now gets an undefined PWA cache id, as unstaged builds do. - panda.config.ts imports src/deployment/default/panda-preset.ts, so that file moves from the app project to the node project (a file in both fails with TS6305). Also for tsconfig.node.json: write the composite build info to node_modules/.tmp rather than the repo root, and list "types": ["node"] explicitly as v6 no longer loads @types/* automatically.
|
Preview build will be at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates TypeScript from 5.9.3 to 6.0.3. v7 is held back for now because of ESLint plugin compatibility;
typescript-eslint8.72.1 supports<6.1.0.Changes
baseUrlfromtsconfig.json. v6 deprecates it (TS5101) and thestyled-system/*path mapping is already relative to the tsconfig.npm run typechecknow also checkstsconfig.node.json(vite.config.ts,panda.config.ts). No script checked it before and it was already failing under 5.9.3. Fixes:vitest/configno longer exportsUserConfig; useViteUserConfig.process.env.BASE_URLis possibly undefined now thatstrictis the default, sopwaCacheIduses optional chaining.panda.config.tsimportssrc/deployment/default/panda-preset.ts, so that file moves from the app project to the node project. It cannot be in both (TS6305).tsconfig.node.jsonwrites its composite build info tonode_modules/.tmprather than the repo root (as the Vite templates do), and lists"types": ["node"]explicitly because v6 no longer loads@types/*automatically.Behaviour change to review
A staged build (
STAGEset) with noBASE_URLused to throw at config load. It now gets an undefined PWA cache id, the same as an unstaged build.Testing
Typecheck, lint, unit tests and the production build pass locally. E2e tests were not run locally.