Repository navigation
Conversation
|
Nice find! But I suggest actually deleting the line, not just commenting it. And then I guess the 2 commented-out lines that use this should be removed as well (or rewritten to use |
The import is commented rather than removed. as all its uses have also been commented out. Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com> Signed-off-by: Jos Verlinde <jos_verlinde@hotmail.com>
6e3a97f to
cb10cf1
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the unused-import and debug-comment cleanup.
No open issues 🎉
What changed in this PR
Removes an unused dependency from the umqtt.simple MQTT client without changing its protocol behavior.
Changes:
- Removes the unused
binascii.hexlifyimport. - Deletes two commented-out debug statements that referenced
hexlify.
| File | Description |
|---|---|
micropython/umqtt.simple/umqtt/simple.py |
Removes the unused import and associated debug comments. |
Review effort: Balanced
|
My assumption was that they are/were intended as a debugging aid. After pondering a while if there would be a way to keep them but be automagically pruned by edit: Sorry for the unintended AI review noise - I have turned automatic reviews off. |
Summary
Remove (commented-out) import of
hexlifyfrom theumqtt.simplemodule as it is not used.This should reduce firmware size and save some memory on import.
Testing
No specific testing was conducted.
Generative AI
I did not use generative AI tools when creating this PR.