Skip to content

Pinning Teams SDK version - #573

Closed
Rodrigo Brandão (rodrigobr-msft) wants to merge 2 commits into
mainfrom
users/robrandao/pin-teams-sdk
Closed

Rodrigo Brandão (rodrigobr-msft) wants to merge 2 commits into
mainfrom
users/robrandao/pin-teams-sdk

Conversation

@rodrigobr-msft

@rodrigobr-msft Rodrigo Brandão (rodrigobr-msft) commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

This pull request makes a minor update to the libraries/microsoft-agents-hosting-msteams/setup.py file, narrowing the version range for the microsoft-teams-api dependency to ensure compatibility with versions >=2.0.16 but less than 2.1.

Copilot AI lite review requested due to automatic review settings September 9, 2026 17:49
@rodrigobr-msft
Rodrigo Brandão (rodrigobr-msft) marked this pull request as ready for review September 9, 2026 17:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The exact == dependency pin in install_requires is likely to cause downstream resolver conflicts and is inconsistent with the repository’s general use of bounded ranges for external dependencies.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This pull request updates the Teams hosting integration package’s dependency constraints to avoid unplanned upgrades of the microsoft-teams-api library.

Changes:

  • Pin microsoft-teams-api to 2.0.16 in libraries/microsoft-agents-hosting-msteams/setup.py instead of allowing any 2.x release.
File summaries
File Description
libraries/microsoft-agents-hosting-msteams/setup.py Tightens the microsoft-teams-api dependency specification for the MSTeams hosting package.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated dependency specifier does not actually “pin” to 2.0.16 as stated in the PR description, so it won’t ensure consistent builds.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants