Repository navigation
Ensure headers get set when rest clients receive an aiohttp.ClientSession instance
#618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Rodrigo Brandão (rodrigobr-msft)
merged 5 commits into
main
from
users/robrandao/user-agent
Oct 5, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7149234
Ensuring headers get set across rest clients
rodrigobr-msft 921143e
Allowing user-specified User-Agent header
rodrigobr-msft ea842e7
Addressing PR feedback
rodrigobr-msft 763611d
Merge branch 'main' of https://github.com/microsoft/Agents-for-python…
rodrigobr-msft ca6c050
updating changelog
rodrigobr-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
|
|
||
| """Tests for MCSConnectorClient User-Agent header behavior.""" | ||
|
|
||
| import pytest | ||
| from aiohttp import web | ||
| from aiohttp.test_utils import TestServer | ||
|
|
||
| from microsoft_agents.activity import Activity | ||
| from microsoft_agents.hosting.core.connector.get_product_info import get_product_info | ||
| from microsoft_agents.hosting.core.connector.mcs import MCSConnectorClient | ||
|
|
||
|
|
||
| class TestMCSConnectorClientUserAgentHeader: | ||
| """Ensures MCSConnectorClient sends a User-Agent header.""" | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_sets_user_agent_header(self): | ||
| client = MCSConnectorClient(endpoint="https://example.org/endpoint") | ||
| try: | ||
| assert client._client.headers.get("User-Agent") == get_product_info() | ||
| finally: | ||
| await client.close() | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_sends_user_agent_header_on_request(self): | ||
| captured = {} | ||
|
|
||
| async def handler(request): | ||
| captured["user_agent"] = request.headers.get("User-Agent") | ||
| return web.json_response({"id": "activity-id-123"}) | ||
|
|
||
| app = web.Application() | ||
| app.router.add_post("/endpoint", handler) | ||
| server = TestServer(app) | ||
| await server.start_server() | ||
| try: | ||
| endpoint = str(server.make_url("/endpoint")) | ||
| client = MCSConnectorClient(endpoint=endpoint) | ||
| try: | ||
| await client.conversations.send_to_conversation( | ||
| "conv-1", Activity(type="message", text="hi") | ||
| ) | ||
| finally: | ||
| await client.close() | ||
| finally: | ||
| await server.close() | ||
|
|
||
| assert captured["user_agent"] == get_product_info() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.