Repository navigation
Update AzureTRE to v0.29.1 and protect active CI runs - #155
Merged
Merged
Conversation
8 tasks done
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Deployment and upgrade validation for the new upstream release remains pending.
Review effort: Balanced
Findings: None
What changed in this PR
Upgrades AzureTRE deployment tooling to v0.29.1 and adds safeguards and validation for cleanup and devcontainer changes.
Changes:
- Pins AzureTRE v0.29.1.
- Defers cleanup while workflows are active or queued.
- Adds cleanup regression tests and devcontainer build validation.
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Updates the AzureTRE release pin. |
.github/scripts/clean_ci_validation_envs.sh |
Protects environments used by active workflows. |
.github/tests/test_clean_ci_validation_envs.py |
Adds mocked cleanup regression coverage. |
.github/workflows/build_validation_develop.yml |
Runs cleanup tests and conditional container validation. |
.github/workflows/clean_validation_envs.yml |
Grants required read permissions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jay W (JayDoubleu)
requested review from
Marcus Robinson (marrobi) and
Max Martin (maxmartin-cgi)
September 21, 2026 09:06
Max Martin (maxmartin-cgi)
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tracking: microsoft/AzureTRE#5084
What is being addressed
AzureTRE-Deployment still installs v0.29.0. AzureTRE v0.29.1 is now available as a pre-release, and this repository's separate cleanup script still lacks its protection for active GitHub Actions runs.
How is this addressed
UPSTREAM_REPO_VERSIONtov0.29.1, which resolves toeed7eada06e658b4c6ebed858b5a3bc9fcec104c..github/scripts/clean_ci_validation_envs.sh. It defers cleanup when another workflow is active or queued and aborts when the GitHub response cannot be checked.Release alignment
Compared
.devcontainerand.githubbetween AzureTRE v0.29.0 and v0.29.1. Upstream devcontainer tooling is unchanged. The deployment repository retains its source-download setup, environment selection and deployment workflows.The upstream PR bot, JavaScript helper tests and their npm dependency configuration do not exist in this repository. The new
skip_deploymentintegration is specific to those PR bot commands. Existing deployment-specific workflows and Dependabot settings are preserved.Validation
git diff --checkpass.d63f504: full devcontainer build, installedv0.29.1source version, source repository, configuration file, TRE CLI and Porter checks.Azure deployment and upgrade validation through AzureTRE-Deployment remain pending. Its main deployment and reusable deployment workflows are currently manually disabled. The earlier passing AzureTRE smoke and extended E2E run is recorded in microsoft/AzureTRE#5084, but does not validate this deployment repository update.