Repository navigation
Update Vite to 7.3.7 and Vitest to 4.1.12 in the UI - #5274
Merged
Jay W (JayDoubleu) merged 2 commits intoOct 23, 2026
Merged
Conversation
Dependabot reports seven alerts in ui/app/package-lock.json. Five alerts are for vite 7.3.6 and two alerts are for @vitest/mocker 4.1.11. Vite 7.3.7 and Vitest 4.1.12 fix all seven advisories: - GHSA-587h-7wmj-h5pm, GHSA-698v-4r3x-3vcv and GHSA-r825-w8mm-5pxw (launch-editor in the Vite development server) - GHSA-rq7h-c2jc-7f22 (files outside server.fs.allow) - GHSA-9jrq-w75r-8gcw (cross-origin script execution through custom middleware) - GHSA-qxg6-89mg-rqv8 and GHSA-xp26-3454-mjgp (@vitest/mocker) Update the pins for vite, vitest, @vitest/ui and @vitest/coverage-v8, and set the UI version to 0.10.4. npm 11.21.1 generated the lock file, so the libc fields of the Rollup packages stay in the file.
Unit Test Results453 tests 453 ✅ 1m 3s ⏱️ Results for commit b76d8b9. |
Collaborator
Author
|
/test b76d8b9 |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/39859163650 (in response to this comment from Jay W (@JayDoubleu)) |
Jay W (JayDoubleu)
requested review from
Chris Chapman (ChrisChapman-gh),
Marcus Robinson (marrobi) and
Max Martin (maxmartin-cgi)
October 22, 2026 21:43
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped dependency updates and release metadata are consistent, reported validation passed, and no blocking defects were identified.
No open issues 🎉
1 file not reviewed
ui/app/package-lock.json: Generated file
What changed in this PR
Updates Azure TRE’s UI development and test dependencies to address seven reported security advisories without changing application code.
Changes:
- Pins Vite to 7.3.7 and Vitest packages to 4.1.12.
- Refreshes affected lockfile dependencies and aligns root dependency specifications.
- Increments the UI version to 0.10.4 and records the fixes in the changelog.
Reported validation includes 453 passing tests, lint, build, and deployment checks. Deployed UI sign-in remains untested.
| File | Description |
|---|---|
ui/app/package.json |
Updates dependency pins and the UI version. |
ui/app/package-lock.json |
Synchronizes resolved dependencies and version metadata. |
CHANGELOG.md |
Documents the security updates under Unreleased bug fixes. |
Review effort: Balanced
Marcus Robinson (marrobi)
approved these changes
Oct 22, 2026
Max Martin (maxmartin-cgi)
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
Dependabot reports seven open alerts in
ui/app/package-lock.json(alerts #628 to #634). The UI pinsvite7.3.6 and Vitest 4.1.11. The fixed versions arevite7.3.7 and@vitest/mocker4.1.12.vitelaunch-editor: on Windows, a request can bypass thefs.existsSync()testvitelaunch-editor:escapeCmdArgs()does not escape%on Windowsvitelaunch-editor: some editors read a file name as a CLI flagviteserver.fs.allowvite@vitest/mocker@vitest/mockerAll seven advisories apply to the development server and the test runner. The deployment script
devops/scripts/build_deploy_ui.shuploads only the static build output inui/app/dist.How is this addressed
viteto 7.3.7.vitest,@vitest/uiand@vitest/coverage-v8to 4.1.12.CHANGELOG.mdunder BUG FIXES.The lock file changes only
vite, the ten Vitest packages and seven dependencies of Vitest (chai,es-module-lexer,obug,std-env,tinyexec,tinyrainbow, andpicomatchinsidevitest). npm 11.9.0 removed thelibcfields from 13@rollup/*entries, but npm 11.21.1 keeps them. The root entry of the lock file now copies thelatestspecs frompackage.jsonin place of*.Validation
I ran these checks on Linux x64 with Node 24.14.0 and npm 11.21.1:
npm audit --package-lock-onlynpm cinpm test -- runnpm run lintnpm run buildnpx vitedev server/and/src/index.tsx, and HTTP 403 for/@fs/etc/passwdpre-commit runon the changed filesnpm auditstill reports one high advisory, GHSA-vfj7-8cjw-p6xm, forbraces3.0.3. The advisory has no patched version, so this PR does not changebraces.The same file tree also ran in a pull request in another fork:
/testrun deployed a full TRE and passed the smoke tests.Deploy UIjob builttre-ui@0.10.4withvite v7.3.7and uploaded it to static web storage.The smoke tests do not open the UI. Nobody signed in to the deployed UI.