Add YAML pipeline for TypeScript DT runs - #1341
Merged
Jake Bailey (jakebailey) merged 5 commits intoSep 17, 2026
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Wesley Wigham (weswigham)
and
a balanced review from Copilot
September 17, 2026 19:50
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 17, 2026 19:55
View session
There was a problem hiding this comment.
🟡 Changes recommended
PR build artifacts can contaminate the base build and produce incorrect comparisons.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds an Azure YAML pipeline for sharded TypeScript PR comparisons against DefinitelyTyped.
Changes:
- Runs 16 parallel dtslint shards against PR and base builds.
- Publishes results and dynamically links Azure logs.
- Adds pipeline execution and release metadata.
File summaries
| File | Description |
|---|---|
.azure-pipelines/typescript-pr-dt.yml |
Defines the build and result-posting jobs. |
.azure-pipelines/scripts/run-typescript-pr-dt.sh |
Builds both revisions and runs sharded comparisons. |
packages/dtslint-runner/src/post-results.ts |
Generates environment-specific Azure log links. |
.changeset/major-boxes-sing.md |
Adds an empty changeset. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
September 17, 2026 20:05
View session
There was a problem hiding this comment.
🟡 Changes recommended
The existing DT trigger does not supply the required parameters or TypeScript repository override.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+9
to
+13
| - name: expected_base_sha | ||
| type: string | ||
| - name: expected_head_sha | ||
| type: string | ||
| - name: expected_merge_sha |
Member
Author
There was a problem hiding this comment.
Correct, I can only do that after I make the pipeline and therefore have the pipeline ID.
Wesley Wigham (weswigham)
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing our non-yaml one.