CmdPal: add an in-place adaptive card updater - #50211
Open
Mike Griese (zadjii-msft) wants to merge 7 commits into
Open
CmdPal: add an in-place adaptive card updater#50211Mike Griese (zadjii-msft) wants to merge 7 commits into
Mike Griese (zadjii-msft) wants to merge 7 commits into
Conversation
As it turns out, the robots are unbelievably stupid. When they build our projects to verify their changes, they will often just build the CS proj that they changed rather than building it in the context of the solution. On the surface, this feels like a good idea. Only build the thing that changed. However, because they're not building it in the context of a solution, the MSBuild variable `$(SolutionDir)` doesn't get expanded to the actual directory of the solution. Instead, it just gets treated as the *path to the project*. This creates terrible recursive loops where the output of a project gets dumped relative to the project itself, and then that gets taken as input to the project's package outputs, and eventually you're gonna end up with a max path overrun. The very easy solution here is to just replace `$(SolutionDir)` with `$(RepoRoot)`. If we use that variable, then the dumb robots will still get the correct value for that variable when they build just a project. And for all the actual humans, everything will work exactly as it did before.
Mike Griese (zadjii-msft)
added
Product-Command Palette
github-actions
Bot
added
the
Needs-Author-Feedback
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a library for in-place updating of our adaptive cards, so that our performance graphs don't flicker anymore.
Warning
Here be basilisks!
This entire library is maintained by LLMs. Humans didn't write the code, and no human actually owns this code.
This library was generated to experiment with the big picture problem "can we update the content of a rendered Adaptive Card without replacing the entire card?"
I would fully suspect that this is not the correct approach to solve this problem. It is an approach however, and it's one that works well enough to continue experimenting with.
Everything in
Microsoft.CmdPal.AdaptiveCards.IncrementalRenderingwas LLM generated and I admittedly, only very lightly reviewed it. I hate myself, but it does work.I don't want to pontificate too highly on the state of ｅｖｅｒｙｔｈｉｎｇ. We're going to need to do more experimentation with projects that are largely LLM maintained1. CmdPal is most definitely not that. It remains human owned.
This is a relatively small and self-contained sub-project that we can pilot what that means for the rest of the broader project.
Closes #46362
Footnotes
much to my own chagrin. ↩