CmdPal: Virtualize grid views and polish it - #50233
Open
Jiří Polášek (jiripolasek) wants to merge 1 commit into
Open
CmdPal: Virtualize grid views and polish it#50233Jiří Polášek (jiripolasek) wants to merge 1 commit into
Jiří Polášek (jiripolasek) wants to merge 1 commit into
Conversation
✅ PR intakeAll automated intake checks now pass. Thanks for the updates! Automated PR intake; PowerToys maintainers make final decisions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Warning
It is
a good ideanecessary to merge #50231 before this.The icon fix not only makes it look good, but also prevents layout cycle.
This PR replaces that implementation with a grouped
GridViewbacked by the nativeItemsWrapGrid, allowing WinUI to realize and recycle only the containers needed for the current viewport.CmdPal grid and gallery pages used a custom
WrapPanelthat measured and arranged every item. This prevented container virtualization and made large result sets increasingly expensive.And because I'm lazy splitting and retesting everything, this PR is packing some other fixes on a way toward making the grid view usable, like keyboard navigation.
ItemsWrapGrid.Pictures? Pictures!
Screen.Recording.2026-08-29.091926.mp4
Screen.Recording.2026-08-29.095121.mp4
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed