FIX: hide converters whose required params the GUI can't supply - #2517
Akshay Babbar (akshay-babbar) wants to merge 1 commit into
Conversation
@microsoft-github-policy-service agree |
|
This is good; however, I was just noticing this and we may be redoing the converter piece so that it always uses the registry (in which case all converters are usable)... So it may be that we approve this but have to redo it. Or I may try to get the more robust fix in. I'll give it a bit of thought. Either way, thank you for bringing it up! |
|
Thanks @rlundeen2 ! |
Fixes #2507 (#2507)
What: the converter catalog projects only string-coercible params, so required
params a form can't supply — like
TokenBijectionConverter'stokenizer— weresilently dropped. The GUI rendered forms that look complete but can only fail at
construction (HTTP 500). 21 catalog entries carried such a param, including
SearchReplaceConverter, which shows requiredpatternwhile hiding requiredreplace.Fix:
ConverterCatalogEntrynow carriesunsupported_required_params— requiredparams not settable through the exposed ones. The converter panel skips flagged entries.
It self-clears once real pickers (tokenizer, target) make those params constructible.
Verification: new backend regression test (TokenBijection →
["tokenizer"],Base64 →
[]); existing suites green — backend 129 passed, API routes 17 passed,frontend jest 78 passed; ruff + tsc clean.
Before
After