MAINT: Decouple CoPyRIT code and infrastructure deployments - #2660
Adrian Gavrila (adrian-gavrila) wants to merge 6 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adrian Gavrila (adrian-gavrila)
changed the title
Behnam (behnam-o)
left a comment
Behnam (behnam-o)
left a comment
There was a problem hiding this comment.
A few comments on keeping the application deployment path uniform.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Behnam (behnam-o)
left a comment
Behnam (behnam-o)
left a comment
There was a problem hiding this comment.
I like how we have separate stages to deploy the infra and the app, and have control on which one to run. These comments are more superficial and readability optimizations and if they're not clear or cause too much churn, I am happy if you decide that we should address them in a Code Quality PR later if they were bugging us.
| dependsOn: | ||
| - Build | ||
| - DeployTestInfra | ||
| condition: >- |
There was a problem hiding this comment.
Also I wonder if we should have a parameter that lets us deploy the app anyways even if deployInfra is true, yet it fails ... I expect this to be useful in our automated ADO pipeline runs, where we probably wanna deploy infra regularly, and even if it fails (for example due to some AFD timeout problem) still deploy the app ... that way we can track infra failures without having to wait on them to be fixed before we can deploy and verify the test app
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
2 participants
Default to code-only test deployment. Add optional infrastructure stages while preserving production opt-in and manual approval. Includes documentation and 27 passing targeted tests. Live code-only deployment validation is pending.
This adds a new checkbox to deploy infra alongside the prod deployment toggle; this defaults to off.
Here is a screenshot of a sample run for a test pipeline using this config. The pipeline passes when deploying to test:
