Run tests/test_sample_quests.py serially on macOS CI - #378
Merged
Marc-Alexandre Côté (MarcCote) merged 2 commits intoSep 29, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started work on behalf of
Marc-Alexandre Côté (MarcCote)
September 29, 2026 12:21
View session
Co-authored-by: MarcCote <660004+MarcCote@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for test_sample_quests
Run tests/test_sample_quests.py serially on macOS CI
Sep 29, 2026
Marc-Alexandre Côté (MarcCote)
marked this pull request as ready for review
September 29, 2026 12:27
Marc-Alexandre Côté (MarcCote)
approved these changes
Sep 29, 2026
Marc-Alexandre Côté (MarcCote)
deleted the
copilot/fix-github-actions-job
branch
September 29, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_sample_quests.py::test_sample_questscrashes on macOS runners: the script it spawns performs native Graphviz/rendering work, which is unsafe when multiple pytest-xdist workers hit it concurrently. Rather than serializing the whole suite on macOS, only this test is taken out of the parallel run..github/workflows/tests.ymlRun testsstep into a Linux step (unchanged,-n 16over the full suite) and a macOS step.--ignore=tests/test_sample_quests.pyand--cov-report=(data collected, no report), then runs that one test serially with--cov-append, emitting the report and enforcing--cov-fail-under=85on the combined data.tests/test_sample_quests.pysys.executableinstead of a barepython, so the subprocess uses the same interpreter as the test process rather than whateverpythonresolves to on the runner. Assertions unchanged.Note the ordering: the serial invocation must come last since it owns
--cov-appendand the threshold check. Runners are ephemeral and no coverage cache is configured, so there is no stale.coverageto append to.