Repository navigation
loopguard: count trial, nosetests and python -m django test as test runs - #307
Closed
Xinghan Pan (PStarH) wants to merge 1 commit into
Closed
Xinghan Pan (PStarH) wants to merge 1 commit into
Xinghan Pan (PStarH) wants to merge 1 commit into
Conversation
The micro-skills observer already reads Twisted's trial, nose's nosetests and python -m nose, and python -m django test as test runs, and SpiralState already counts trial. But status_of_tests in loopguard/turn.py read none of them because VERIFY_RE did not list them. A failing run after the last edit then left the turn counted as ended green. Add trial and nosetests to the runner heads, and nose and django test after python -m.
Author
|
Closing in favor of earlier PR #294 by Lanre Shittu (@Shizoqua) which addresses the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291
Summary
The micro-skills observer already reads Twisted's
trial, nose'snosetestsandpython -m nose, andpython -m django testas test runs (inrunner_headsandrunner_modulesinmicroskills/observe.py), andSpiralStatealready countstrialinTEST_RUN_RE.However,
status_of_testsinloopguard/turn.pydid not recognize them becauseVERIFY_REdid not list them. A failing run after the last edit then left the turn counted as ended green.Changes
tokeneconomizer/loopguard/turn.py: addtrialandnoseteststo the runner heads inVERIFY_RE, and addnoseanddjango\s+testto the_PYTHON\s+-malternation.tests/test_loopguard_trial_nose_django.pytesting positive verifications, non-run commands (such astrial --helpandpython -m django runserver), and agreement with the observer.Verification
All 26 tests in
tests/test_loopguard_trial_nose_django.pypass.