Repository navigation
microskills: charge the proposer's call when its CLI reports no usage - #314
Open
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Open
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Lanre Shittu (Shizoqua) wants to merge 1 commit into
Conversation
Every paid side call is charged to the ledger as overhead. The loop guard's judge and redirect writer charge the usage their runner recovered, else an estimate on the same basis (`pricing.runner_effective_or_approx`: the prompt at 1x and the reply at 5x). The micro-skills proposer charged only recovered usage (`if eff is not None`), so a call whose CLI reported none added nothing to `opt_tokens`, and the ledger's overhead and overhead share left it out. Cursor's side calls never report usage; the others do not when the usage block is missing. The proposer is now charged through `runner_effective_or_approx` too. Recovered usage, an on-device call's 0 and a failed call (not charged) are as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every paid side call is charged to the ledger as overhead. The loop guard's judge and redirect writer charge the usage their runner recovered, else an estimate on the same basis (
pricing.runner_effective_or_approx: the prompt at 1x and the reply at 5x). The micro-skills proposer charged only recovered usage (if eff is not None), so a call whose CLI reported none added nothing toopt_tokens, and the ledger's overhead and overhead share left it out. Cursor's side calls never report usage; the others do not when the usage block is missing.Fix: the proposer is charged through
runner_effective_or_approxtoo, as the judge is. Recovered usage, an on-device call's 0, and a failed call (not charged) are as before. The experiments' proposer and cost-basis tests pass unchanged.Tests, in a new
tests/test_proposer_cost.py:runner_effective_or_approxgives, as the judge charges (fails on main);The skips need Windows, a real agent CLI (Codex, Hermes, opencode) or aider, or a non-root user.
Fixes #312