Followup to STDIN PR - #41703
Merged
Merged
Followup to STDIN PR#41703
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Only minor documentation timing clarifications remain; no blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Follow-up improving SDK stdin coverage, flag handling, maintainability, and API documentation.
Changes:
- Added C and WinRT stdin tests for init and exec processes.
- Refined process flag validation and propagation.
- Clarified process-settings lifecycle documentation.
| File | Summary |
|---|---|
test/windows/WslcSdkWinRTTests.cpp |
Adds WinRT stdin helpers and coverage. |
test/windows/WslcSdkTests.cpp |
Adds C SDK stdin coverage and helpers. |
src/windows/WslcSDK/wslcsdk.h |
Clarifies process flag lifecycle. |
src/windows/WslcSDK/wslcsdk.cpp |
Refines unknown-flag validation. |
src/windows/WslcSDK/winrt/ProcessSettings.cpp |
Applies process flags consistently. |
doc/docs/api-reference/csharp/settings-classes/processsettings.md |
Clarifies configuration timing. |
doc/docs/api-reference/cpp/settings-classes/processsettings.md |
Clarifies configuration timing. |
doc/docs/api-reference/c/process-apis/wslcsetprocesssettingsflags.md |
Clarifies C API usage timing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Blue (OneBlue)
approved these changes
Sep 25, 2026
David Bennett (dkbennett)
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Followup to #41698 that makes changes only to docs, tests, and maintainability aspects of the code.
PR Checklist
Detailed Description of the Pull Request / Additional comments
PR feedback from the previous change as none of it required any functionality changes to the product code.
Validation Steps Performed
Ran the modified tests.