Repository navigation
fix(deps): report the proxy archive rejection instead of a later HTTP 404 - #3375
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 3 commits into
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 3 commits into
Mohammed Alkindi (MohammedAlkindi) wants to merge 3 commits into
Conversation
When a registry proxy URL returns 200 but the archive is rejected (unsafe member such as a symlink, or a body that is not a zip), the loop moved on to the remaining fallback URLs and their 404s overwrote the cause, so the error ended in "Last error: HTTP 404". Track the first archive rejection separately and report it when no URL succeeds. A later valid archive still wins. Refs microsoft#3110
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Behind
PROXY_REGISTRY_URL, a rejected proxy archive (symlink member or non-zip body) was followed by fallback 404s, so the error read "Last error: HTTP 404". The download now keeps the first rejection and reports it asArchive error:when no URL succeeds. A later valid archive still wins.Issue and approved scope
Issue: Refs #3110
Human scope-approval comment: #3110 (comment)
Does this PR complete the issue, or what remains? No: diagnostic slice only; symlink handling stays deferred.
Type of change
Testing
Spec conformance (OpenAPM v0.1)
docs/src/content/docs/specs/openapm-v0.1.mdupdated (new/changed<a id="req-XXX"></a>anchor + prose + Appendix C row).docs/src/content/docs/specs/manifests/openapm-v0.1.requirements.ymlupdated.@pytest.mark.req("req-XXX")test undertests/spec_conformance/added or extended.CONFORMANCE.{md,json}regenerated viauv run --extra dev python -m tests.spec_conformance.gen_statementand committed.