[reuben olinsky (reubeno)]

Summary

Extract the existing LISA integration into internal/lisa: definition/source parsing, criteria, runbook generation, framework/venv setup, invocation, and helper tests. The image command retains selection and dispatch and calls lisa.RunTestDefinition directly, without forwarding wrappers.

Move the existing shared image-format inference and format ordering from the boot command into utils/imageformat, with its tests. Boot and LISA use that neutral helper rather than making LISA depend on command-package code.

This is the third extraction in the planned build/test refactor, following #415 and #416. It is independent of the parallel TMT extraction. Existing qcow2-only behavior, arguments, diagnostics, work paths, cached checkouts, venv reuse, key handling, runbook contents, and cleanup remain unchanged. No new framework capabilities, artifact policies, runtime isolation, or result semantics are introduced.

Validation

• mage all — passed, including code generation/build, unit tests, default quality checks, scenarios, and CLI/schema generation.
• git diff --check upstream/main...HEAD — passed.
• Mechanically compared moved function/test bodies against upstream after package/type renames. All original helper and format-inference tests are retained.
• Added an in-memory command invocation test covering image name/path, local framework override, native arguments, generated criteria, and runbook cleanup.
• No schema or snapshot changes; discarded generated CLI-doc drift limited to the local 0.0.0-devel version label.

mage fix all completed Go formatting/linting with zero issues, then stopped at optional Python autofixing because ruff is unavailable. No Python source changed; the required mage all pipeline passed independently. Native E2E tests were not run.

[Copilot]

🟢 Approval recommended

No active review issues remain for the LISA execution and shared image-format refactor.

No open issues 🎉

What changed in this PR

Continues the build/test refactor from #415 and #416 by extracting LISA execution from the image command package into internal/lisa, while preserving existing behavior.

Changes:

• Moves LISA parsing, runbook generation, setup, invocation, and helper tests into a dedicated package.
• Extracts shared image-format inference and ordering into internal/utils/imageformat.
• Updates command dispatch and adds in-memory coverage for LISA option forwarding and runbook cleanup.

File	Description
internal/​utils/​imageformat/​imageformat.go	Houses shared format constants, ordering, and inference.
internal/​utils/​imageformat/​imageformat_test.go	Retains extracted format-helper tests.
internal/​lisa/​runner.go	Extracts LISA execution with dedicated options.
internal/​lisa/​runner_internal_test.go	Retains argument, format, and checkout-resolution tests.
internal/​lisa/​runbook.go	Moves runbook generation into LISA ownership.
internal/​lisa/​runbook_internal_test.go	Moves runbook tests alongside implementation.
internal/​lisa/​criteria.go	Moves criteria parsing into LISA ownership.
internal/​lisa/​criteria_internal_test.go	Moves criteria tests alongside implementation.
internal/​app/​azldev/​cmds/​image/​test.go	Calls LISA and shared format helpers directly.
internal/​app/​azldev/​cmds/​image/​test_test.go	Adds LISA dispatch and cleanup coverage.
internal/​app/​azldev/​cmds/​image/​test_internal_test.go	Relocates LISA-specific tests to the new package.
internal/​app/​azldev/​cmds/​image/​boot.go	Uses shared helpers while retaining boot-specific validation.
internal/​app/​azldev/​cmds/​image/​boot_test.go	Relocates shared format tests to the utility package.

_{Review effort: Balanced}