Make natvis find winmds from the WinMD Reference - #1631
Open
Yexuan Xiao (YexuanXiao) wants to merge 3 commits into
Open
Yexuan Xiao (YexuanXiao) wants to merge 3 commits into
Yexuan Xiao (YexuanXiao) wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix microsoft/WindowsAppSDK#2809.
Currently, the VSIX extension only looks for winmd files from the exe directory and the system directory, making the visualization useless. In particular, metadata from the WindowsAppSDK was also not taken into consideration.
This patch passes the information of all winmd references to the binary through MSBuild, which is then parsed by the VSIX plugin to obtain the paths of the referenced winmd files. All of this is automatic.
All winmds are loaded lazily. When looking up a type, the extension first collects the paths of all winmd files, and then looks for the appropriate file based on the namespace of the type. Once a namespace has been looked up, it is recorded to avoid repeating a futile load the next time.
This patch also fixes the issue where natvis does not support reading winmd files under non-ASCII paths, because std::filesystem::path::string transcodes UTF-16 to ACP, and the Debugger's ACP is determined by Windows locale settings and is not always UTF-8.
std::filesystem::path::string has already been deprecated in C++26. If a UTF-8 path is needed, path.u8string() or winrt::to_string(path.native()) should be used.