Feat/locale ja - #466
Open
Zulfazli (fazelllyyy) wants to merge 1 commit into
Open
Feat/locale ja#466Zulfazli (fazelllyyy) wants to merge 1 commit into
Zulfazli (fazelllyyy) wants to merge 1 commit into
Conversation
Translate all 10 frontend locale domains into Japanese in polite desu/masu form (1860 keys, full parity with en). Register the bundle in locales/index.ts and i18n/index.ts, and cover key parity with a unit test. The language switcher label and backend language support for Japanese already existed, so no changes were needed there.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full Japanese (
ja) support for the frontend i18n system, following the same pattern as #436 (Hindi) and #463 (Indonesian). Related to #337 (International Language Support).Changes
src/i18n/locales/ja/— all 10 domains translated (common,upload,chart,model,encoding,messages,navigation,dataLoading,loader,errors) plus theindex.tsaggregatorjainsrc/i18n/locales/index.tsand in theresourcesmap insrc/i18n/index.ts(it flows automatically intoSUPPORTED_UI_LANGUAGES)tests/frontend/unit/app/i18nLocales.test.tswith aja-vs-enkey-parity testsrc/app/App.tsx(ja: '日本語'label already existed) or in the backend ("ja"already exists inLANGUAGE_DISPLAY_NAMESalong with its polite-form extra rule, so agent language instructions work out of the box)Translation notes
{{interpolation}}placeholders,_pluralforms, and inline HTML tags (<refreshAction>,<strong>) preserved verbatimTRANSLATION_GUIDE.md(chart types, channel keys, spec values); tooltips (encoding.channel*_tip,chart.templateNames.*) translated insteadloader.jsonleft literalchart.vegaLocalelocalized (Japanese day/month names, 午前/午後 periods); no code change needed invega-locale.tsVerification
index.ts): en/hi/zh/id/ja each resolve to exactly 1860 keys — 0 missing, 0 extra, 0 placeholder/tag mismatchesjakey alignment withenvitest/tscrun was not possible in this environment (nonode_modulesavailable); please rely on CI