Skip to content

Move agentic package guidance into package references and tsc build info into node_modules/.cache - #4393

Merged
Jason Morse (JasonVMo) merged 3 commits into
mainfrom
user/jasonvmo/agentic-instruction-rework
Oct 23, 2026
Merged

Jason Morse (JasonVMo) merged 3 commits into
mainfrom
user/jasonvmo/agentic-instruction-rework

Conversation

@JasonVMo

@JasonVMo Jason Morse (JasonVMo) commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

No runtime behavior changes. This PR changes agent guidance, package documentation, published package contents, and TypeScript build-cache locations.

Description of changes

Fixes #4388. Every packages/agentic/* package and framework-base is now in the guided package registry.

TypeScript build-info cache location

  • tsBuildInfoFile now points to <workspace>/node_modules/.cache/<config>.tsbuildinfo instead of <workspace>/.cache/. Yarn never packs node_modules, and Git ignores it, so incremental build state can't be published or committed.
  • scripts/src/tasks/constrain.ts enforces this location for each workspace tsconfig.json, plus any composite or incremental tsconfig.*.json or targets/tsconfig*.json. Every affected tsconfig was updated with yarn constraints --fix.
  • check-package-contents no longer requires files that a package excludes on purpose with a negated files pattern. It still flags packed .cache contents.

Package-owned agent guidance

  • Moves components, native-core, design, and framework-base to the package guidance standard (references/agents/repository/package-guidance.md). Each package has a concise AGENTS.md router, a user README.md, and an indexed references/ folder that ships with the package.
  • The agentic component recipes (types and slots, state, styles, rendering, tests) and the contract source adapters move from references/agents/components/agentic/ into packages/agentic/components/references/. The nested src/**/AGENTS.md files become references such as source-boundaries, higher-order-components, and primitives. Framework-base's src/accessibility/AGENTS.md and its src/*/README.md utility docs move into packages/framework-base/references/.
  • Native-core's long README is split into architecture, entry-point, modern-component, codegen/publishing, contributing, and RNmacOS-patch references.
  • Package plans are removed (design/PLAN.md, components/WIN32-FOCUS-PLAN.md, SPEC-MIGRATION.md). Open work now lives in each package's references/remaining-work.md. New rule R-PKGDOC-009 is enforced by check-agent-instructions, which rejects plan files outside a guided package's references/.
  • Components and framework-base now limit published contents with a files allowlist.
  • Root AGENTS.md, references/agents/ (index, classification, focus, native, TypeScript, and evals), and the shim READMEs now link to the new locations.

Root skills

  • I re-checked all ten .github/skills against the new layout. They link to package entry points and indexed references.
  • review-component sends contract and provenance reviews to the components package's contracts reference and source-adapter index.
  • agentic-component-contract-authoring no longer duplicates the contract schema rules (R-PKGDOC-006). It points to references/contracts.md.
  • implement-native-component links native-core's layout and Swift-interop architecture notes and names native-core's codegen:windows --check and test:apple-integration scripts.
  • maintain-desktop-testing now covers the runtime package, which keeps its validation in AGENTS.md because it has no contributing reference.

Changesets

  • build-info-node-modules.md covers every package touched by the tsconfig cache move.
  • components-native-core-guidance.md and design-framework-base-guidance.md cover the guidance and files changes.

Verification

All runs were on macOS.

Command Result
yarn check-agent-instructions Passed
yarn clean-lage-cache then yarn lage buildci (cold cache) Passed: 175 succeeded, 0 failed, 0 skipped. Includes build, lint, test, check-agent-instructions, and check:spec-contracts
yarn oxfmt .github/skills Passed; no further changes
yarn lage test-links Passed: 88 succeeded, 0 failed
yarn change:check Passed

Not run: native app builds and desktop story lanes. No native source changed.

Before After
tsbuildinfo written to <workspace>/.cache, which could be packed. Agentic recipes in references/agents/components/agentic/ and nested src/**/AGENTS.md. Package plans at package roots tsbuildinfo written to <workspace>/node_modules/.cache. Package guidance in <package>/AGENTS.md and <package>/references/. Open work in references/remaining-work.md. Root skills act as routers

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

Route review and contract work to the components package contracts and
source-adapter index, link native-core architecture notes and validation
scripts from the native skill, note the runtime package's validation entry in
the desktop-testing maintenance skill, and drop the duplicate tsc cache
changeset.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 64 (+2) 65 (+2) 50.63k (+687b) 50.55k (+687b)
components-catalog 214 (+55) 215 (+55) 205.49k (+50.22k) 205.41k (+50.22k)
design-theme-state 34 (+1) 35 (+1) 30.15k (+42b) 30.08k (+42b)
design-themed-root 38 (+1) 39 (+1) 32.12k (+42b) 32.04k (+42b)
design-color-lib 6 (+0) 6 (+0) 6.33k (+0b) 6.33k (+0b)
design-theme-state-legacy-source 35 (+1) 36 (+1) 31.81k (+42b) 31.73k (+42b)
design-legacy-theme-from-flex 58 (+1) 59 (+1) 97.77k (+42b) 97.63k (+42b)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

@JasonVMo
Jason Morse (JasonVMo) enabled auto-merge (squash) October 23, 2026 22:29
@JasonVMo
Jason Morse (JasonVMo) merged commit cfa4c66 into main Oct 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend package-owned agent guidance to agentic and framework-base packages

2 participants