Repository navigation
FIX: Finalize Conda build and release workflows - #842
Gaurav Sharma (bewithgaurav) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR Performance Report✅ No regression detectedNo consistent slowdowns detected across all 2 environments. 0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS Coverage: 2 of 2 environments completed. Advisory result; does not block merging. Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsUnix / SQL Server 2022
Unix / SQL Server 2025
Build and measurement detailsPR head:
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
There was a problem hiding this comment.
🟢 Approval recommended
The targeted fixes are consistent, documented, and covered by focused regression tests.
0 open findings
What changed in this PR
Corrects Conda matrix propagation and Windows ARM64 cross-build targeting.
Changes:
- Isolates POSIX Python matrix variables.
- Uses
target_platformwhile keeping Windows builds native. - Adds documentation and regression coverage.
| File | Description |
|---|---|
OneBranchPipelines/steps/conda-build-validate-step-posix.yml |
Isolates the Python matrix input. |
eng/conda_tools/build.py |
Separates Windows build and target platforms. |
eng/conda_tools/environment.py |
Documents build/verification environment behavior. |
conda/README.md |
Documents cross-build and matrix handling. |
tests/test_027_conda_release_metadata.py |
Tests POSIX matrix propagation. |
tests/test_034_conda_verify_cwd.py |
Tests build and verification environments. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Port the remaining final Conda changes from ADO c436c39ba5080bfdde4fb7298e07846638ba76e2 while preserving the existing build fixes and unrelated GitHub source versions. Keep focused regression coverage for the matrix and publisher credential boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
3dbf8fa
Override request call-time defaults so Requests Session.get cannot re-enable redirects. Extend the existing focused rehearsal regression to cover its redirect default. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 62.6%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.connection.connection_pool.cpp: 82.3%
mssql_python.pybind.connection.connection.cpp: 83.1%
mssql_python.logging.py: 86.2%
mssql_python.pooling.py: 90.1%
mssql_python.pybind.fetch_temporal.hpp: 92.1%
mssql_python.cursor.py: 92.5%🔗 Quick Links
|



AB#48877
Summary
Sync the final ADO Conda fixes: Python matrix isolation, Windows ARM64 cross-builds, and the verified publisher/rehearsal workflow. Preserve provenance, native audits, and credential safeguards with focused regression coverage.
Validation
924 tests passed. Pinned Black and YAML/PowerShell syntax checks passed.