ci: enable WHP FreeBSD PCAT ISO boot test - #162
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The test should explicitly verify that both Windows PCAT exclusions remain.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Enables the FreeBSD 13.2 PCAT ISO boot test in the WHP CI lane.
Changes:
- Removes the test’s exact WHP exclusion.
- Updates unit-test expectations for two remaining exclusions.
| File | Description |
|---|---|
scripts/nvx_tools/ci.py |
Enables the FreeBSD ISO boot test. |
scripts/test_nvx_tools.py |
Updates WHP exclusion assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused filter change is correct, exact-match behavior is preserved, and regression coverage reflects the intended exclusions.
Review effort: Balanced
Findings: None
Resolved since last review (1)
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The required virtual-machine runner validation has not yet passed, despite being an explicit acceptance criterion.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
| @@ -134,7 +134,6 @@ def _exclude_openvmm_tests( | |||
| "x86_64::openvmm_uefi_x64_windows_datacenter_core_2022_x64_battery_capacity", | |||
| ) | |||
| OPENVMM_WHP_EXCLUDED_TESTS = ( | |||
CI root-cause resolutionThe failing WHP VMM job was caused by runner provisioning, not the FreeBSD images:
Commit The updated setup was rolled through all five The exact-head failed jobs were rerun successfully: https://github.com/microsoft/nvx/actions/runs/35612178865 |
Enable the full Microsoft Hyper-V feature for runner-only Windows WHP hosts so OpenVMM can access the in-box PCAT and SVGA firmware. Preserve restart requirements while enabling multiple optional features, and validate that the required firmware DLLs are present during both runner setup and CI runner validation. Remove the FreeBSD 13.2 PCAT ISO boot test from the WHP exclusion list now that its firmware dependency is available. Update configuration tests and setup documentation to cover the new runner requirements.
b95acc3 to
944975d
Compare
Summary
multiarch::openvmm_pcat_x64_freebsd_13_2_x64_iso_boot_no_agentin the WHP VMM laneNo OpenVMM pin change is required.
Validation
Related: #135
CI runner prerequisite
The required virtual WHP lane failed before VM creation because the runner image enabled
HypervisorPlatformbut notMicrosoft-Hyper-V. Consequently,vmfirmwarepcat.dll/vmfirmware.dllandVmEmulatedDevices.dllwere absent fromSystem32.The passing bare-metal host has full Hyper-V enabled and all three in-box firmware files. This PR now:
Microsoft-Hyper-Vduring runner-only provisioning;The existing Windows runner pool must be reprovisioned and rebooted with the updated setup script before the PCAT lane can pass.