[code-improvement] deduplication: centralize performance result identity - #167
Merged
Pedro Henrique Penna (ppenna) merged 1 commit intoSep 21, 2026
Conversation
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 21, 2026 16:51
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused refactor preserves existing identity semantics and is covered by the performance test suite.
Review effort: Balanced
Findings: None
What changed in this PR
Centralizes performance-result identity construction without changing existing deduplication or fallback-platform behavior.
Changes:
- Adds
_result_identity. - Reuses it for validation and persistence filtering.
- Removes four duplicate tuple constructions.
| File | Description |
|---|---|
scripts/nvx_tools/performance.py |
Centralizes five-field result identity handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
force-pushed
the
dev
branch
from
September 21, 2026 16:52
6a294c7 to
0a0e392
Compare
Pedro Henrique Penna (ppenna)
marked this pull request as ready for review
September 21, 2026 16:57
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pedro Henrique Penna (ppenna)
force-pushed
the
code-improvement/dedupe-performance-result-identity-c8f77cadced171f7
branch
from
September 21, 2026 21:42
4d4383d to
e254cad
Compare
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 21, 2026 21:43
View session
Pedro Henrique Penna (ppenna)
deleted the
code-improvement/dedupe-performance-result-identity-c8f77cadced171f7
branch
September 21, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: deduplication
Centralizes the repeated five-field performance result identity tuple in a private
_result_identityhelper and uses it for current-result validation, cross-file validation, and persisted-result filtering. This preserves the existing fallback-platform behavior while removing four independently maintained tuple constructions.Evidence: the same platform/ABI/processors/commit/metric identity was assembled repeatedly in
scripts/nvx_tools/performance.py. The currentdevbaseline passed, so no failing-check scope applied. Recent code-improvement outcomes were reconciled: all nine marked pull requests were merged without maintainer rejection or changes-requested feedback. The higher-weightcode-qualitycandidates were rejected because they duplicated prior selections or overlapped active work; no open issue, pull request, or active performance-file change covers this helper extraction.Changed files:
scripts/nvx_tools/performance.pyonly. Patch size: 16 additions + 32 deletions = 48 changed lines.Validation (all passed):
python3 -m unittest scripts/test_performance.py -v(48 tests)python -m unittest scripts/test_performance.py -qpython -m unittest scripts/test_performance.py scripts/test_nvx_tools.py scripts/test_microvm_tests.py scripts/test_development_release.py -qpython -m compileall -q scriptspython -m ruff check scriptspython -m pyright --pythonplatform Linuxpython -m pyright --pythonplatform Windowspython -m ruff format --check scriptspython .github/skills/nvx-host-connect/scripts/test_hosts.py -vpython scripts/nvx.py --helppython scripts/nvx.py test-openvmm-unit --helppython scripts/nvx.py test-openvmm --helppython scripts/nvx.py test-microvm --helppython scripts/nvx.py benchmark --helpgit diff --checkNo dependency, public API/CLI/ABI, gitlink, or OpenVMM change was made.