Skip to content

test: improve mutation coverage ahead of cargo-gamma adoption - #954

Merged
Martin Taillefer (geeknoid) merged 1 commit into
mainfrom
mutants
Nov 13, 2026
Merged

Martin Taillefer (geeknoid) merged 1 commit into
mainfrom
mutants

Conversation

@geeknoid

Copy link
Copy Markdown
Member

…o-gamma

Copilot AI balanced review requested due to automatic review settings November 7, 2026 18:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several tests invoke unsupported native backtrace capture or incorrectly assume distinct thread IDs under Miri, and a new integration executable lacks required tracing initialization.

6 open issues
What changed in this PR

This PR prepares the Rust workspace for cargo-gamma mutation testing by adding focused regression coverage, exposing hard-to-observe behavior through test hooks, and documenting prospective mutation exclusions.

Changes:

  • Add boundary, ownership, cleanup, telemetry, and error-propagation tests across the workspace.
  • Introduce test instrumentation and small helper refactors for synchronization and native calls.
  • Document mutation-exclusion rationale and update test dependencies and diagnostic snapshots.

This pull request requires changes. The unresolved moderate findings concern Miri compatibility, relocation fixtures that do not guarantee distinct thread identities, and an insufficient URI-validation assertion. Minor findings also cover tracing initialization and deterministic TLS fixtures.

File Description
crates/​tick/​src/​timer.rs Tests overflowing timer periods.
crates/​tick/​src/​runtime/​inactive_clock.rs Tests isolated storage preservation during relocation.
crates/​tick/​src/​error.rs Tests formatting-error propagation with backtraces.
crates/​tick/​src/​delay.rs Tests registration cleanup and overflow handling.
crates/​tick/​src/​clock.rs Tests isolated clock storage relocation.
crates/​thread_aware/​src/​relocate.rs Documents a planned parameter-mutation exclusion.
crates/​thread_aware_core/​src/​thread.rs Extracts and tests owner-counter allocation.
crates/​thread_aware_benchmarking/​src/​model.rs Documents benchmark-support mutation exclusions.
crates/​testing_aids/​tests/​gamma_round2_wrappers.rs Tests synchronous and asynchronous harness forwarding.
crates/​testing_aids/​tests/​gamma_round2_uninitialized.rs Tests tracing helpers before initialization.
crates/​testing_aids/​src/​tracing_logs/​format.rs Documents the ANSI-setting exclusion.
crates/​testing_aids/​src/​tracing_logs/​capture.rs Documents constructor equivalence to Default.
crates/​testing_aids/​src/​macro_expansion.rs Serializes expansion-helper tests.
crates/​templated_uri/​src/​origin.rs Documents authority-check mutation equivalence.
crates/​templated_uri/​src/​base_uri.rs Documents root-path conversion equivalence.
crates/​templated_uri_macros_impl/​src/​template_parser.rs Documents parser mutation equivalences.
crates/​templated_uri_macros_impl/​src/​struct_template.rs Documents parsed-path invariants.
crates/​templated_uri_macros_impl/​src/​lib.rs Documents empty-attribute mutation equivalence.
crates/​seismograph/​tests/​record.rs Tests independently enabled recording categories.
crates/​seismograph/​tests/​monitor_io.rs Tests startup directory-error propagation.
crates/​seismograph/​tests/​gamma_round2_recorder_identity.rs Tests stable, consecutive recorder identities.
crates/​seismograph/​tests/​gamma_round2_event_measurement.rs Tests numeric event payload preservation.
crates/​seismograph_rallocator/​tests/​gamma_survivor_publication.rs Tests publication-state toggling.
crates/​seismograph_protocol/​src/​discovery.rs Tests cached directory-owner mismatch diagnostics.
crates/​seismograph_protocol/​src/​codec.rs Tests byte decoding and documents capacity exclusions.
crates/​seismograph_io/​tests/​gamma_survivor_buffer.rs Tests buffer metadata and saturation.
crates/​seismograph_io/​src/​lib.rs Documents conversion and recording-call exclusions.
crates/​seismograph_cli/​src/​commands/​monitor/​task_events.rs Documents a tie-group mutation timeout.
crates/​seismograph_cli/​src/​commands/​monitor/​snapshot.rs Tests duplicate allocator-source diagnostics and progress.
crates/​seismograph_cli/​src/​commands/​monitor/​runtime_timeline.rs Tests timeline-bin boundaries.
crates/​seismograph_cli/​src/​commands/​monitor/​filter.rs Tests symbol parsing and documents a mutation limit.
crates/​seatbelt/​tests/​gamma_round2_context_relocation.rs Tests clock ownership notifications during relocation.
crates/​seatbelt/​src/​retry/​layer.rs Tests retry type-state configuration preservation.
crates/​seatbelt/​src/​chaos/​latency/​service.rs Tests zero-rate random-boundary behavior.
crates/​seatbelt/​src/​chaos/​latency/​layer.rs Tests equal latency bounds without random consumption.
crates/​seatbelt/​src/​breaker/​health.rs Tests saturating execution-count subtraction.
crates/​seatbelt/​src/​breaker/​health_eval.rs Documents zero-total threshold equivalence.
crates/​seatbelt/​src/​breaker/​engine/​probing/​single_probe.rs Tests probe cooldown boundaries and replacement.
crates/​seatbelt/​src/​breaker/​engine/​engines.rs Tests default-engine identity and named storage.
crates/​seatbelt/​src/​breaker/​engine/​engine_telemetry.rs Documents wildcard-assignment exclusions.
crates/​seatbelt_http/​src/​http_clone.rs Documents default clone-policy equivalence.
crates/​routerama/​src/​query/​from_query.rs Documents parser-strategy equivalence.
crates/​routerama/​src/​dyn_builder.rs Documents empty-set formatting equivalence.
crates/​routerama/​src/​decode.rs Documents nontermination mutation exclusions.
crates/​routerama/​src/​codegen_helpers/​scanned_path.rs Documents scanning and allocation-path equivalences.
crates/​routerama_build/​src/​trie.rs Documents conflict, specificity, and sanitization exclusions.
crates/​routerama_build/​src/​macro_impl/​mod.rs Documents parser and diagnostic equivalences.
crates/​routerama_build/​src/​macro_impl/​field.rs Tests capture-type rejection and documents path invariants.
crates/​routerama_build/​Cargo.toml Enables procedural-macro span locations.
crates/​rest_over_grpc/​src/​context.rs Documents header-removal order equivalence.
crates/​rest_over_grpc/​src/​build/​http_rule.rs Tests field-path deduplication and documents capacity exclusions.
crates/​rallocator/​src/​sync_fence.rs Adds test-observable fence dispatch.
crates/​rallocator/​src/​lib.rs Registers the fence helper module.
crates/​rallocator/​src/​hal/​x86_64/​mod.rs Documents processor-hint mutation exclusions.
crates/​plurality/​tests/​gamma_round2_local_reuse.rs Tests layout diagnostics and borrowed-slot reuse.
crates/​plurality/​src/​sync.rs Tests reference-count overflow handling.
crates/​plurality/​src/​rc.rs Tests increment results and overflow handling.
crates/​plurality/​src/​multi_builder.rs Documents default chunk-sizing equivalence.
crates/​plurality/​src/​lib.rs Registers native test hooks.
crates/​plurality/​src/​layout_pool.rs Documents sizing and unreachable fallback exclusions.
crates/​plurality/​src/​directory.rs Tests unused-capacity checks and documents retry assertions.
crates/​plurality/​src/​atomic.rs Wraps fences for test observation.
crates/​performables/​tests/​ui/​early_release_requires_capability.stderr Updates expected capability diagnostics.
crates/​performables/​tests/​ui/​affinity_requires_thread_safe_values.stderr Updates expected conditional-trait diagnostics.
crates/​performables/​src/​telemetry.rs Removes a disabled-recording test and documents conversion equivalence.
crates/​performables/​src/​sync/​raw_mutex.rs Records test lock attempts and documents timeout exclusions.
crates/​performables/​src/​sync/​once.rs Tests initialization flags and contention telemetry.
crates/​performables/​src/​sync/​mutex/​hal/​portable.rs Documents a wait-parameter mutation timeout.
crates/​performables/​src/​sync/​mutex/​hal/​mod.rs Tests ownership transfer and adjusts mutation exclusions.
crates/​performables/​src/​sync/​mod.rs Registers effects instrumentation and documents barrier exclusions.
crates/​performables/​src/​sync/​lock/​native.rs Tests native contention-event recording.
crates/​performables/​src/​sync/​lock/​hal/​portable.rs Tests guard ownership and explicit release.
crates/​performables/​src/​lib.rs Registers telemetry test helpers.
crates/​performables/​src/​gamma_round2_telemetry.rs Adds shared recorder initialization and event counting.
crates/​ohno/​tests/​gamma_round2.rs Tests borrowed terminal-error labels.
crates/​ohno/​src/​error_label.rs Documents default-return equivalence.
crates/​ohno/​src/​error_ext.rs Documents an error-chain mutation timeout.
crates/​ohno/​src/​core.rs Tests empty display and backtrace writer errors.
crates/​ohno/​src/​app/​error.rs Documents error-chain traversal timeout exclusions.
crates/​ohno_macros_impl/​src/​message.rs Documents brace-search and comma-parser equivalences.
crates/​ohno_macros_impl/​src/​error_attr/​mod.rs Removes redundant semicolon assignment and clarifies span commentary.
crates/​ohno_macros_impl/​src/​derive_error/​validate.rs Tests exact core-field selection.
crates/​ohno_macros_impl/​src/​derive_error/​generate/​conversions.rs Documents unused trailing-index equivalence.
crates/​ohno_macros_impl/​src/​derive_error/​display/​template.rs Tests complete template segmentation.
crates/​observed/​src/​value.rs Documents unreachable integer-conversion fallbacks.
crates/​observed/​src/​sampling/​context.rs Documents processor-loop timeout exclusions.
crates/​observed/​src/​processing/​event_state.rs Tests prohibited NoopEvent field access.
crates/​observed_macros_impl/​src/​lib.rs Registers macro regression tests.
crates/​observed_macros_impl/​src/​gamma_round2.rs Tests attribute consumption and empty predicates.
crates/​observed_destination_core/​tests/​format.rs Tests brace rendering and writer-error propagation.
crates/​observed_destination_core/​src/​format.rs Documents brace-search equivalence.
crates/​multitude/​src/​vec/​freeze.rs Documents freeze-prefix invariants.
crates/​multitude/​src/​vec/​basic.rs Tests growth policy and documents equivalent paths.
crates/​multitude/​src/​lib.rs Registers the fence helper module.
crates/​multitude/​src/​de/​value.rs Registers regressions and documents deserializer equivalences.
crates/​multitude/​src/​de/​limits.rs Registers regressions and documents unlimited-limit equivalences.
crates/​multitude/​src/​de/​json.rs Tests callback-error preservation and termination.
crates/​multitude/​src/​de/​containers/​tests.rs Tests large-element reservation and trailing-access errors.
crates/​multitude/​src/​de/​containers.rs Documents no-op reservation equivalence.
crates/​multitude/​src/​bytesbuf.rs Uses observable fences and tests block-state diagnostics.
crates/​multitude/​src/​arena/​alloc_slice_box.rs Documents unused slice-length mutation equivalence.
crates/​multitude/​src/​arena_builder.rs Documents capacity and construction equivalences.
crates/​multitude/​src/​arc.rs Routes fences through the observation helper.
crates/​multitude_macros_impl/​Cargo.toml Adds span-location and syntax-visitor test features.
crates/​metabench/​src/​mode.rs Extracts and tests platform-dependent default modes.
crates/​metabench/​src/​gungraun_perf.rs Tests section activation and cleanup.
crates/​metabench_macros_impl/​tests/​gamma_survivor_macro_errors.rs Tests macro errors and argument-complexity limits.
crates/​internity/​src/​stable_fx.rs Tests single-byte hashing and documents boundary equivalence.
crates/​internity/​src/​shard.rs Tests generation changes for distinct insertions.
crates/​internity/​src/​de/​inherent.rs Tests bounded zero-sized capacity hints.
crates/​internity_macros_impl/​src/​shared.rs Tests validation and simplifies transparent default generation.
crates/​internity_macros_impl/​src/​serialize.rs Documents single-field selection equivalence.
crates/​internity_macros_impl/​src/​hygiene.rs Documents identifier-loop timeout exclusions.
crates/​internity_macros_impl/​src/​deserialize.rs Documents index and single-field selection equivalences.
crates/​http_headers/​tests/​gamma_nov6_contracts.rs Tests header wire formats and builder errors.
crates/​http_headers/​tests/​field_value_allocations.rs Tests retained-header round trips without allocations.
crates/​http_headers/​tests/​cors_tokens.rs Tests preservation of empty repeated field lines.
crates/​http_headers/​src/​sink/​field_encoder.rs Documents digit-buffer initialization equivalence.
crates/​http_headers/​src/​sink/​encoded_values.rs Tests inline storage and spill reservations.
crates/​http_headers/​src/​headers/​shared.rs Tests later formatting errors and documents helper equivalences.
crates/​http_headers/​src/​headers/​set_cookie.rs Documents decode-mode and sensitivity equivalences.
crates/​http_headers/​src/​headers/​security/​content_security_policy.rs Documents unused decode-mode equivalence.
crates/​http_headers/​src/​headers/​range/​content_range.rs Documents formatting equivalence and trimming-loop exclusions.
crates/​http_headers/​src/​headers/​negotiation/​weighted_token_scan.rs Documents byte-fold chunk-width equivalence.
crates/​http_headers/​src/​headers/​negotiation/​quality.rs Documents fractional-digit modulus equivalence.
crates/​http_headers/​src/​headers/​negotiation/​negotiation_parameter.rs Documents validated quoting invariants.
crates/​http_headers/​src/​headers/​negotiation/​accept_scan.rs Documents byte-fold chunk-width equivalence.
crates/​http_headers/​src/​headers/​negotiation/​accept_language_entry.rs Documents encoded-length summation equivalence.
crates/​http_headers/​src/​headers/​negotiation/​accept_entry.rs Documents parameter-boundary and length equivalences.
crates/​http_headers/​src/​headers/​negotiation/​accept_encoding_entry.rs Documents encoded-length summation equivalence.
crates/​http_headers/​src/​headers/​location/​uri_authority.rs Documents IPvFuture prefix-search equivalence.
crates/​http_headers/​src/​headers/​location/​metadata.rs Documents validated URI search-needle equivalences.
crates/​http_headers/​src/​headers/​cors/​cors_tokens.rs Documents iterator nontermination exclusions.
crates/​http_headers/​src/​headers/​cors/​access_control_max_age.rs Documents unused decode-mode equivalence.
crates/​http_headers/​src/​headers/​cors/​access_control_allow_credentials.rs Documents unit-value and trimming equivalences.
crates/​http_headers/​src/​headers/​conditional/​if_range.rs Documents redundant weak-validator rejection.
crates/​http_headers/​src/​field.rs Makes unused policy parameters anonymous.
crates/​http_headers/​src/​field_value.rs Tests inline conversion boundaries and documents buffer equivalence.
crates/​http_headers/​Cargo.toml Adds allocation tracking for tests.
crates/​http_headers_simd/​src/​scalar.rs Documents token-padding suffix equivalence.
crates/​http_headers_simd/​src/​list.rs Tests persistent rejected scan state.
crates/​http_headers_simd/​src/​dispatch/​portable.rs Adds portable forwarding and byte-position regressions.
crates/​http_headers_simd/​src/​api.rs Documents ASCII reduction equivalences.
crates/​http_extensions/​tests/​gamma_round2.rs Tests request failures and repeated routing.
crates/​http_extensions/​src/​routing/​router.rs Tests routing caches and documents URI-conversion equivalence.
crates/​http_extensions/​src/​routing/​router_context.rs Documents constructor equivalence to Default.
crates/​http_extensions/​src/​http_utils.rs Documents zero content-length encoding equivalence.
crates/​http_extensions/​src/​extensions/​request_ext.rs Documents URI-conversion equivalence.
crates/​http_extensions/​src/​body/​timeout_body.rs Tests timeout cleanup and terminal polling.
crates/​http_compression/​src/​body.rs Tests compression-error cleanup and terminal state.
crates/​fundle_macros_impl/​src/​newtype.rs Documents validated single-field selection.
crates/​fetch/​tests/​november4_native_default.rs Tests native-only TLS transport configuration.
crates/​fetch/​tests/​gamma_round2_native_default.rs Tests native-only client construction.
crates/​fetch/​src/​telemetry.rs Tests metering diagnostics and documents value equivalences.
crates/​fetch/​src/​handlers/​dispatch.rs Tests dispatch diagnostics and documents a validation mutation timeout.
crates/​fetch/​src/​dispatch_builder.rs Tests omission of empty decompression configuration.
crates/​fetch/​src/​client.rs Tests requests without alternative routers.
crates/​fetch/​src/​client_builder.rs Tests resilience name and meter forwarding.
crates/​fetch_winhttp_impl/​src/​testing/​recording.rs Tests sequential and repeated response scripts.
crates/​fetch_winhttp_impl/​src/​receiver_drop_calls.rs Observes and suppresses repeated destruction attempts.
crates/​fetch_winhttp_impl/​src/​header_capacity_calls.rs Injects oversized header lengths for tests.
crates/​fetch_winhttp_impl/​src/​handle.rs Tests raw-handle pointer diagnostics.
crates/​fetch_winhttp_impl/​src/​bindings/​real.rs Routes unit-test native calls through interception helpers.
crates/​fetch_winhttp_impl/​src/​bindings/​facade.rs Tests real-facade diagnostics without native calls.
crates/​fetch_tls/​src/​backend_builder.rs Documents constructor equivalence to Default.
crates/​fetch_options/​tests/​gamma_survivor_contracts.rs Tests lifetime resolution and keep-alive defaults.
crates/​fetch_options/​src/​connection_keep_alive.rs Documents disabled-policy equivalence.
crates/​fetch_hyper/​tests/​gamma_survivor_contracts.rs Tests native TLS identity construction.
crates/​fetch_hyper/​src/​telemetry.rs Tests exact connection-attribute ordering.
crates/​fetch_hyper/​src/​connection/​tracked_stream.rs Tests vectored-write capability forwarding.
crates/​fetch_azure/​tests/​gamma_survivor_contracts.rs Tests empty and nonempty Azure body adaptation.
crates/​fakeable_test/​tests/​gamma_survivor_services.rs Tests real and fake service forwarding.
crates/​fakeable_test/​src/​my_service.rs Documents side-effect-free fixture calls.
crates/​fakeable_test/​src/​my_service_mockall.rs Documents side-effect-free fixture helpers.
crates/​fakeable_impl/​src/​args.rs Documents boolean lookahead invariants.
crates/​fakeable_impl/​Cargo.toml Declares an expansion regression target.
crates/​data_privacy/​src/​sensitive.rs Documents formatting-buffer and fallback equivalences.
crates/​data_privacy/​src/​redactors/​mod.rs Documents overwritten hexadecimal-buffer initialization.
crates/​data_privacy/​src/​redaction_engine.rs Adds private engine-state inspection for tests.
crates/​data_privacy/​src/​redaction_engine_inner.rs Tests retained redactor-capacity compaction.
crates/​data_privacy_macros_impl/​tests/​gamma_survivor_contracts.rs Tests taxonomy naming and invalid macro inputs.
crates/​data_privacy_macros_impl/​src/​classified.rs Documents validated single-field selection.
crates/​compressors/​tests/​public_api.rs Tests pooled raw-deflate reset behavior.
crates/​compressors/​src/​resources.rs Documents a constructor mutation timeout.
crates/​compressors/​src/​limits.rs Tests exact ratio and stream-limit diagnostics.
crates/​compressors/​src/​error.rs Documents an error-chain traversal timeout.
crates/​compressors/​src/​builder.rs Documents constructor equivalence to Default.
crates/​cachet/​tests/​gamma_round2_request_ids.rs Tests successive request correlation identities.
crates/​cachet/​src/​transform/​tier.rs Tests transform-adapter diagnostic fields.
crates/​cachet/​src/​serialize/​codec.rs Tests borrowed contiguous input and documents writer equivalence.
crates/​cachet/​src/​builder/​transform.rs Tests telemetry propagation and tier roles.
crates/​cachet/​src/​builder/​cache.rs Tests optional eviction-hook installation.
crates/​cachet/​src/​builder/​buildable.rs Tests inherited primary and fallback roles.
crates/​cachet_tier/​tests/​gamma_round2_debug.rs Tests mock-cache diagnostic labels.
crates/​cachet_memory/​tests/​gamma_survivor_builder.rs Tests default builder diagnostic fields.
crates/​cachet_memory/​src/​policy.rs Documents default eviction-policy equivalence.
crates/​bytesbuf/​src/​view_read.rs Documents empty-read equivalence.
crates/​bytesbuf/​src/​telemetry.rs Tests identity reset after empty transfer.
crates/​bytesbuf/​src/​lib.rs Registers the fence helper module.
crates/​bytesbuf/​src/​bytes_compat/​view.rs Documents empty vectored-output equivalence.
crates/​bytesbuf/​src/​bytes_compat/​to_bytes.rs Documents single-span selection equivalence.
crates/​bytesbuf/​src/​buf_put.rs Documents looped append-path equivalence.
crates/​bytesbuf_io/​src/​testing/​pending.rs Documents ignored pending-read byte counts.
crates/​bytesbuf_io/​src/​testing/​null.rs Documents ignored null-read byte counts.
crates/​arty/​tests/​gamma_survivor_configuration.rs Tests default worker stack-size diagnostics.
crates/​arty/​src/​task/​scheduler.rs Documents unused relocation-source equivalence.
crates/​arty/​src/​task/​preparation/​cleanup.rs Tests disposal of panicking captures and payloads.
crates/​arty/​src/​task/​handle/​join_handle.rs Tests cancellation publication and documents assertion equivalence.
crates/​arty/​src/​task/​context.rs Documents relocation-source argument equivalences.
crates/​arty/​src/​runtime/​worker/​joiner.rs Tests panic disposal and remaining-worker joins.
crates/​arty/​src/​runtime/​worker/​asynchronous/​signal.rs Tests driver-waker installation and notifications.
crates/​arty/​src/​runtime/​worker/​asynchronous/​protocol.rs Tests command diagnostics and queued-capture cleanup.
crates/​arty/​src/​runtime/​worker/​asynchronous/​local_worker.rs Extracts and tests worker-access gating.
crates/​arty/​src/​runtime/​config/​workers_policy.rs Documents singleton processor-selection equivalence.
crates/​arty/​src/​io/​handle.rs Documents unused relocation-source equivalence.
crates/​arty_io_host/​tests/​hosting.rs Tests cycle recovery and initialization reentry errors.
crates/​arty_io_host/​src/​runtime.rs Tests prior failure propagation and documents mutation exclusions.
crates/​arty_executor/​tests/​inspection.rs Strengthens diagnostics and panic-payload cleanup tests.
crates/​arty_executor/​tests/​gamma_survivor_panic.rs Tests the panic-payload disposal boundary.
crates/​arty_executor/​src/​telemetry.rs Tests exact default-placement telemetry.
crates/​arty_executor/​src/​task_options.rs Documents no-op sink reporting equivalences.
crates/​anyspawn/​tests/​gamma_survivor_spawner.rs Tests diagnostics and explicit Tokio runtime selection.
crates/​anyspawn/​tests/​arty.rs Strengthens the Arty spawner diagnostic assertion.
crates/​anyspawn_azure/​tests/​gamma_survivor_yield.rs Tests yield polling and wake counts.
crates/​allocation_hints/​tests/​gamma_survivor_heaps.rs Tests heap options, identities, and cloning.
Cargo.lock Records the new header-test dependency.

Review effort: Balanced

Comment thread crates/ohno/src/core.rs Resolved
Comment thread crates/tick/src/clock.rs Resolved
Comment thread crates/tick/src/error.rs Resolved
Comment thread crates/rallocator/src/pagemap.rs Resolved
@psandana

Copy link
Copy Markdown
Contributor

🤖 Pato's Pull Request Agent: The fmt check is failing on all four target jobs (linux-arm64, linux-x64, windows-arm64, and windows-x64). Please run the repository formatter and commit the formatting fixes before merging; this leaves the PR's required checks red.

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Comment thread crates/rallocator/src/core.rs Dismissed
Comment thread crates/rallocator/src/core.rs Dismissed
Comment thread crates/rallocator/src/core.rs Dismissed
Comment thread crates/rallocator/src/pagemap.rs Dismissed
Comment thread crates/rallocator/src/pagemap.rs Dismissed
Comment thread crates/rallocator/src/pagemap.rs Dismissed
Comment thread crates/rallocator/src/pagemap.rs Dismissed
Copilot AI balanced review requested due to automatic review settings November 8, 2026 01:06
@geeknoid Martin Taillefer (geeknoid) changed the title Fix a bunch of cargo-gamma mutants in anticipation of turning on carg… test: improve mutation coverage ahead of cargo-gamma adoption Nov 8, 2026
@geeknoid

Copy link
Copy Markdown
Member Author

Amended and pushed 5d197b4. Fixed formatting, compiler-version UI snapshots, platform-specific test assumptions, tracing initialization, and native-only runtime-analysis cases. Also fixed ReadAsFuturesStream so pending reads use separate source storage and Debug never borrows that source while a read is active (one extra allocation when constructing the adapter, not per poll). Native regressions, MSRV/coverage-toolchain UI tests, Clippy, formatting, README generation, and spelling checks passed. Miri and mutation testing remain CI-only. Replied to and resolved the eight review threads. Reviewed the 40 CodeQL annotations against their SARIF flows and recorded specific false-positive dismissal evidence. Fresh CI is pending; monitoring continues.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The tests still rely on uncontrolled cryptographic randomness and accept any nonempty error instead of verifying the expected uri_invalid cause.

2 open issues
6 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 8, 2026 01:35
@geeknoid

Copy link
Copy Markdown
Member Author

Amended and pushed 78f5260. Addressed both new review comments, platform-specific Clippy failures, the Unix peer-owner assertion, and isolated-package test feature failures. Focused Rust 1.95 tests, Anvil Clippy, README generation, and spelling checks passed locally. New CI runs are underway; monitoring continues, with Miri and mutation testing left to CI.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test asserts Vec’s resulting capacity, which is not an API contract, instead of verifying that the deserializer requests a reservation of one element.

1 open issue
2 resolved since last review

Review effort: Balanced

@geeknoid

Copy link
Copy Markdown
Member Author

Pushed ee62134. Addressed the reservation-test feedback and the latest Linux build/coverage failures: feature-dependent integration targets now declare their prerequisites, and the bytesbuf pool test is separate from the no_std-compatible fence tests. Focused std/no_std tests, isolated no-default-feature builds, and Anvil Clippy passed. CI is rerunning; monitoring continues.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The review remained incomplete because one or more reviewers received a runtime budget-stop instruction.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 8, 2026 02:16
@geeknoid

Copy link
Copy Markdown
Member Author

Pushed 9c3c79f to fix the cargo-sort failure: the fakeable_impl test-target table now follows its dependency tables. Cargo sorting and Anvil Clippy pass locally. CI is rerunning; monitoring continues.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The self-referential storage change retains an unsafe lifetime extension across pending polls and cancellation, requiring human soundness review and Miri validation of aliasing and destruction guarantees beyond source inspection.

No open issues 🎉

Review effort: Balanced

@geeknoid

Copy link
Copy Markdown
Member Author

Pushed 8601961. Added the two missing license headers in gamma.toml and the immutable macro fixture. The license check, fixture regression, and Anvil Clippy pass locally. CI is rerunning; monitoring continues.

Copilot AI balanced review requested due to automatic review settings November 8, 2026 02:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the workspace test and mutation-coverage improvements.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review reports no active issues with the regression-test enhancements and mutation-exclusion documentation.

No open issues 🎉

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues require further changes.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified that would block approval.

No open issues 🎉

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain to block approval.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The coverage and mutation configurations exclude the raw-deflate reset and native-default TLS regression tests, leaving these behaviors unchecked by those automated gates.

2 open issues

Review effort: Balanced

Comment thread crates/compressors/tests/public_api.rs Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Parallel tests share a global telemetry snapshot, allowing unrelated recorder activity to cause flaky timeouts and panics because thread-ID filtering occurs too late to isolate observations.

1 open issue
2 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The FFI and unsafe ownership boundaries in native WinHTTP interception and fence/abort instrumentation require Windows-native, Miri, and Loom validation results; source inspection alone cannot establish equivalence.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review reports no active issues with the mutation-testing preparation changes.

No open issues 🎉

Review effort: Balanced

Comment thread crates/rallocator/src/buddy.rs Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the workspace test-hardening changes.

No open issues 🎉

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Comment thread crates/metabench/src/allocation.rs Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The native-TLS regression test asserts successful client-identity creation on non-macOS Apple platforms, where the API explicitly does not support it.

1 open issue

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The watchdog remains enabled during Gamma mutation runs, contrary to documented requirements, and can fail the test before Gamma reports a timeout.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread crates/performables/tests/sync.rs Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the regression-coverage and mutation-testing preparation changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the regression-coverage and mutation-exclusion changes.

No open issues 🎉

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the regression-test additions and documented mutation-test exclusions.

No open issues 🎉

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Cross-crate instrumentation affects final-owner reclamation and allocator fences, requiring human confirmation of memory-ordering and teardown invariants alongside native, no_std, and Loom validation.

No open issues 🎉

Review effort: Balanced

…o-gamma

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7a49a612-6ba0-4a9e-bf4d-da6e0248dc5c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues require further changes.

No open issues 🎉

Review effort: Balanced

@martin-kolinek martin-kolinek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖: Approved with suggestions — the review comments are non-blocking; take them or leave them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants