Skip to content

feat(rallocator)!: add selectable Rust mimalloc backend - #976

Open
Ralf Biedert (ralfbiedert) wants to merge 33 commits into
mainfrom
ralfbiedert-allocator-personality-switching
Open

Ralf Biedert (ralfbiedert) wants to merge 33 commits into
mainfrom
ralfbiedert-allocator-personality-switching

Conversation

@ralfbiedert

@ralfbiedert Ralf Biedert (ralfbiedert) commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 Applications need a build-time allocator choice without changing allocation call sites or losing diagnostics. This adds a pure Rust mimalloc option alongside snmalloc.

rallocator!() keeps snmalloc as the default. Use rallocator!(backend = mimalloc) to select mimalloc or rallocator!(backend = snmalloc) to select snmalloc explicitly. Both backends use the common Rallocator facade. This change does not add runtime switching.

The snmalloc implementation moves into its own backend. The mimalloc port preserves native allocation classes, page ownership, remote frees, abandoned-page handling, arena management, and memory policy. Production code does not link the native mimalloc library.

Rallocator records allocation, resize, and free events. A successful resize records both storage addresses before the old block becomes reusable. Backend-specific state views and saved stack symbols make captures useful after the producer exits. The change preserves upstream's demand-driven runtime diagnostics and recording-independent allocator observations.

The CLI keeps live monitor and offline view. This removes the obsolete snapshot html command, its renderer and assets, and export-only test support.

BREAKING CHANGE: Rallocator is now backend-parameterized. Install it through the macro. Direct construction is hidden and unsafe. Readers accept only snapshot format 10, allocator schema 5, runtime schema 9, and monitor protocol 9. Previous formats are rejected. The public event and allocator codec enums also gain variants. The CLI removes snapshot html and its HTML-only test-util feature. Version changes happen at release time.

All fast-tier check groups passed, including final individual reruns. Workspace Clippy, documentation, formatting, generated READMEs, spelling, and external-type checks passed. The complete generated Windows coverage gate passed with all features and without default features. Every package met its existing threshold.

Tests and documentation examples passed for the six allocator and diagnostics packages on Windows x64 and Linux x64. Rust 1.95 tests and Linux cargo-careful checks also passed for those packages. Miri passed for the recorder, allocator schema, protocol, and selected portable allocator checks.

The initial mutation run found nine surviving changes. Consumer regressions and focused reruns closed eight. One redundant branch was removed.

The complete workspace anvil-pr tier was not run. CI must still cover macOS and ARM.

🤖 Preserve the complete allocator and telemetry implementation before rebasing. Add compile-time backend selection, backend-specific snapshots, captured stack symbols, and first-class resize events. Accept only current snapshot and monitor formats.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Update allocator and viewer tests for the current recorder API and schema identifiers. Clear retained buffers before testing disabled runtime instrumentation. Regenerate crate documentation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Keep the event-building closures value-returning and terminate the unit-returning recorder calls.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Construct the benchmark handle explicitly while keeping Criterion on the system allocator. Borrow the channel used by the state-test worker.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Document the Linux Miri check for cached TLS. The corresponding Windows path uses native assembly and remains covered by native tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Preserve one orphan allocation lifetime across consecutive moves when the capture contains no original allocation event. Exercise the monitor preparation boundary with address-based correlation keys.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Check orphan labels on the correct resize row and verify final-size allocation-to-free totals. Remove a redundant resize category from the traffic-only iterator; operation rows still retain every resize.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Check resize operation labels and distinguish known allocation origins from orphan resizes at the complete monitor preparation boundary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Verify original allocation and final free labels beside the resize label. The focused monitor-row mutation run covers these assertions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Remove the duplicate null guard from the common event builder. Rallocator already rejects failed requests before recording.

Cover failed normal and zeroed requests through both public backend selections. Keep the failed-resize case within GlobalAlloc's valid-size contract.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Use Event::allocation directly when checking that failed allocation requests produce no records.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 17:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changes can abort on macOS through allocator-lock reentry and fabricate source locations by merging filename, line, and column from different lookups.

5 open issues
What changed in this PR

This PR adds build-time selection between Rust snmalloc and mimalloc backends while keeping snmalloc as the default. It extends Seismograph diagnostics and viewers to preserve resize history, backend-specific state, and saved stack symbols.

Changes:

  • Introduces backend selectors and separates snmalloc from the shared allocator interface.
  • Adds resize events, backend-aware snapshots, saved symbols, and strict format-version handling.
  • Updates terminal and HTML views, regression tests, documentation, and macOS checks.
File Description
docs/​runtime-analysis.md Documents backend coverage and portable Miri tests.
crates/​seismograph/​tests/​snapshot_symbols.rs Tests saved symbols without registered sources.
crates/​seismograph/​tests/​reallocation.rs Tests resize recording, validation, and sampling.
crates/​seismograph/​src/​recorder/​event.rs Adds resize event kinds, payloads, and accessors.
crates/​seismograph/​src/​recorder/​alloc.rs Defines resize fields and correlation semantics.
crates/​seismograph/​src/​recorder.rs Adds platform-specific symbol lookup adjustment.
crates/​seismograph/​src/​monitor.rs Preserves cache policy in monitor configuration.
crates/​seismograph/​src/​lib.rs Documents saved stack symbols.
crates/​seismograph/​README.md Regenerates symbol-capture documentation.
crates/​seismograph/​Cargo.toml Adds native symbol-resolution dependency.
crates/​seismograph_runtime/​tests/​on_demand.rs Clears buffers before disabled-recording assertions.
crates/​seismograph_runtime/​src/​lib.rs Documents accepted runtime versions.
crates/​seismograph_runtime/​README.md Regenerates runtime compatibility documentation.
crates/​seismograph_rallocator/​tests/​native.rs Tests rejection of previous allocator schemas.
crates/​seismograph_rallocator/​tests/​borrowed_allocator.rs Tests allocation-free mimalloc encoding and validation.
crates/​seismograph_rallocator/​src/​snmalloc.rs Defines snmalloc-specific snapshot state.
crates/​seismograph_rallocator/​src/​snapshot.rs Introduces shared headers and typed backend snapshots.
crates/​seismograph_rallocator/​src/​observation.rs Centralizes backend-neutral observation controls.
crates/​seismograph_rallocator/​src/​native.rs Reexports shared controls for existing callers.
crates/​seismograph_rallocator/​src/​lib.rs Exposes backend-aware models and source identifiers.
crates/​seismograph_rallocator/​src/​codec.rs Updates snmalloc encoding to the current schema.
crates/​seismograph_rallocator/​src/​callers.rs Adds resize and recorder-identity fields.
crates/​seismograph_rallocator/​README.md Regenerates backend and resize documentation.
crates/​seismograph_protocol/​tests/​monitor_io.rs Tests rejection of other protocol versions.
crates/​seismograph_protocol/​src/​monitor.rs Updates descriptor version expectations.
crates/​seismograph_protocol/​src/​lib.rs Advances monitor protocol to version 9.
crates/​seismograph_protocol/​README.md Regenerates protocol compatibility documentation.
crates/​seismograph_cli/​tests/​snapshot_symbols.rs Tests offline HTML use of saved symbols.
crates/​seismograph_cli/​tests/​render_html.rs Updates schema fixtures and publication wording assertions.
crates/​seismograph_cli/​tests/​reallocation.rs Tests resize history and HTML summaries.
crates/​seismograph_cli/​tests/​mimalloc_html.rs Tests backend-specific HTML and missing-state evidence.
crates/​seismograph_cli/​src/​snapshot_symbols.rs Merges shared and source-specific symbol data.
crates/​seismograph_cli/​src/​snapshot_error.rs Defines snapshot and backend validation errors.
crates/​seismograph_cli/​src/​report.rs Renders mimalloc state and resize records.
crates/​seismograph_cli/​src/​native_view.rs Updates publication limitation text for resizes.
crates/​seismograph_cli/​src/​mimalloc_view/​fixture.rs Adds deterministic backend snapshot fixtures.
crates/​seismograph_cli/​src/​main.rs Documents backend navigation and registers new modules.
crates/​seismograph_cli/​src/​commands/​monitor/​task_events/​tests.rs Tests task histories across allocation moves.
crates/​seismograph_cli/​src/​commands/​monitor/​task_events.rs Groups resize events by retained allocation lifetime.
crates/​seismograph_cli/​src/​commands/​monitor/​panels.rs Routes scrolling to the selected backend.
crates/​seismograph_cli/​src/​commands/​monitor/​offline.rs Updates fixtures and tests mimalloc loading.
crates/​seismograph_cli/​src/​commands/​monitor/​native_ui.rs Shares rendering helpers with the mimalloc view.
crates/​seismograph_cli/​src/​commands/​monitor/​mouse.rs Routes mouse selection by backend.
crates/​seismograph_cli/​src/​commands/​monitor/​mod.rs Registers mimalloc UI and backend tests.
crates/​seismograph_cli/​src/​commands/​monitor/​live_activity.rs Removes legacy recorder-statistics fallback.
crates/​seismograph_cli/​src/​commands/​monitor/​info_ui.rs Removes unsupported legacy-server display state.
crates/​seismograph_cli/​src/​commands/​monitor/​help.rs Adds backend-specific help contexts.
crates/​seismograph_cli/​src/​commands/​monitor/​filter_index.rs Preserves backend state and resize identities through filters.
crates/​seismograph_cli/​src/​commands/​monitor/​client/​io_tests.rs Updates tests for required protocol metadata.
crates/​seismograph_cli/​src/​allocator_view.rs Stores mimalloc state and current format metadata.
crates/​seismograph_cli/​src/​allocation_identities.rs Maps recorder events to allocation lifetimes.
crates/​seismograph_cli/​README.md Regenerates viewer and compatibility documentation.
crates/​seismograph_cli/​Cargo.toml Adds temporary-directory support for tests.
crates/​rallocator/​tests/​state.rs Uses the installed allocator and backend-aware decoding.
crates/​rallocator/​tests/​snapshot_source_soundness.rs Validates current-schema snmalloc state.
crates/​rallocator/​tests/​mimalloc.rs Runs mimalloc allocation and alignment contracts.
crates/​rallocator/​tests/​mimalloc_sampling.rs Tests allocator event sampling decisions.
crates/​rallocator/​tests/​mimalloc_events.rs Tests resize events and failed allocations.
crates/​rallocator/​tests/​fixtures/​mimalloc-round-size.csv Records upstream size-rounding reference values.
crates/​rallocator/​tests/​events.rs Updates snmalloc assertions for resize events.
crates/​rallocator/​tests/​backend_selection.rs Tests explicit backend selection and ownership.
crates/​rallocator/​src/​lib.rs Adds backend-selecting macro forms and documentation.
crates/​rallocator/​src/​backend/​snmalloc/​snapshot.rs Registers and captures snmalloc snapshot state.
crates/​rallocator/​src/​backend/​snmalloc/​remote.rs Updates remote-free paths for the backend module.
crates/​rallocator/​src/​backend/​snmalloc/​ranges.rs Relocates range management and test references.
crates/​rallocator/​src/​backend/​snmalloc/​pagemap.rs Updates module paths and allocator test construction.
crates/​rallocator/​src/​backend/​snmalloc/​observation.rs Updates observation paths and test allocator handles.
crates/​rallocator/​src/​backend/​snmalloc/​mod.rs Assembles the snmalloc backend modules.
crates/​rallocator/​src/​backend/​snmalloc/​hal/​x86_64/​mod.rs Provides x64 prefetch and pause operations.
crates/​rallocator/​src/​backend/​snmalloc/​hal/​win64/​mod.rs Updates Windows backend references.
crates/​rallocator/​src/​backend/​snmalloc/​hal/​macos/​mutex.rs Provides an allocation-free Darwin mutex.
crates/​rallocator/​src/​backend/​snmalloc/​hal/​macos/​mod.rs Updates macOS backend and test references.
crates/​rallocator/​src/​backend/​snmalloc/​hal/​linux/​mod.rs Updates Linux backend and test references.
crates/​rallocator/​src/​backend/​snmalloc/​hal/​aarch64/​mod.rs Provides ARM64 prefetch and pause operations.
crates/​rallocator/​src/​backend/​snmalloc/​core.rs Relocates core allocation and observation references.
crates/​rallocator/​src/​backend/​snmalloc/​combining.rs Updates combining-lock platform and test paths.
crates/​rallocator/​src/​backend/​snmalloc/​buddy.rs Updates buddy allocator module references.
crates/​rallocator/​src/​backend/​snmalloc/​allocator.rs Implements snmalloc operations and resize preparation.
crates/​rallocator/​src/​backend/​mod.rs Defines sealed backend operations and selectors.
crates/​rallocator/​src/​backend/​mimalloc/​pagemap.rs Maps allocation addresses to page metadata.
crates/​rallocator/​src/​backend/​mimalloc/​mod.rs Assembles and documents the Rust mimalloc backend.
crates/​rallocator/​src/​backend/​mimalloc/​LICENSE-MIMALLOC Includes the upstream license notice.
crates/​rallocator/​src/​backend/​mimalloc/​hal/​x86_64.rs Reads Windows x64 thread information.
crates/​rallocator/​src/​backend/​mimalloc/​hal/​virtual_memory.rs Wraps virtual memory operations with failure injection.
crates/​rallocator/​src/​backend/​mimalloc/​hal/​linux_policy.rs Parses Linux memory policy settings.
crates/​rallocator/​src/​backend/​mimalloc/​hal/​aarch64.rs Reads Windows ARM64 thread information.
crates/​rallocator/​src/​backend/​mimalloc/​atomic.rs Wraps conditional atomic updates for compiler compatibility.
crates/​rallocator/​src/​backend/​mimalloc/​allocator.rs Implements mimalloc operations and resize preparation.
crates/​rallocator/​src/​backend/​abort.rs Shares invariant-abort support between backends.
crates/​rallocator/​README.md Regenerates backend-selection and resize documentation.
crates/​rallocator/​benches/​rallocator_telemetry.rs Uses an explicitly constructed snmalloc handle.
Cargo.toml Adds backtrace dependency and symbol-test debug information.
Cargo.lock Locks symbol-resolution and test dependencies.
.spelling Adds resize terminology to the dictionary.
.github/​workflows/​repository-checks.yml Includes the CLI in native macOS checks.

Review effort: Balanced

🤖 Share the existing inline Darwin mutex between allocator backends. The standard library allocates pthread mutex storage on first lock, which reenters mimalloc during arena creation.

Preserve lock poisoning and leave allocation geometry and memory policy unchanged. Existing whole-process mimalloc tests cover the startup path.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 17:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Several rendering and decoding tests violate repository policy by relying on filesystem access, subprocesses, or loader threads, while documentation also misstates publication behavior and the supported dependency version.

5 open issues
3 previously missed issues

In code that hasn't changed since last review

Low severity Update the dependency example to version 0.4.0

crates/​rallocator/​src/​lib.rs:30

This requirement selects the 0.3 release line and excludes the 0.4.0 package declared in crates/rallocator/Cargo.toml:6. Readers copying the dependency and the new backend-selection example are therefore directed to an older release line. Match the dependency example to this crate's version and regenerate the README from these doc comments.

Low severity Correct publication-policy documentation and regenerate the README

crates/​seismograph_cli/​src/​main.rs:40

Sampled-out operations can publish state: crates/rallocator/src/allocator.rs:71,81,105 calls publish_state() without checking event acceptance, and both backend publishers check whether allocation recording is enabled. Describe publication as controlled by the allocation policy, not event acceptance, so users can correctly interpret fresh observations with no retained event. Correct the same claim in crates/seismograph_cli/src/native_view.rs:20–21, then regenerate the crate README.

Low severity Remove filesystem and CLI dependencies from rendering tests

crates/​seismograph_cli/​tests/​mimalloc_html.rs:19

These rendering tests write input fixtures and spawn the CLI through support::render_capture or support::render_html (tests/support/mod.rs:16–39), contrary to the repository test policy. Run the capture bytes through a shared in-process decode/render entry point and keep the existing HTML assertions. Apply the same change to crates/seismograph_cli/tests/snapshot_symbols.rs:44–55, which performs these operations directly.

Review effort: Balanced

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

🤖 A 128-TiB reservation can succeed on ARM hosts with wider address spaces. Use a valid 4-EiB request to test allocation failure and recovery without changing native allocation limits.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🤖 Keep source filenames and coordinates from a single lookup so overrides cannot fabricate locations.

Use controlled events and scripted symbol resolution in snapshot tests. Extract the existing CLI into a library-backed executable, gate in-memory rendering utilities behind test-util, and feed the offline decoder through a reader.

Preserve the HTML assertions without temporary input files, subprocesses, or compiler-generated marker frames.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 18:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The warnings and test assertion incorrectly tie state publication to retained events, and the dependency example selects 0.3.x rather than the documented package’s 0.4.0 release.

2 open issues
5 resolved since last review

Review effort: Balanced

Comment thread crates/rallocator/src/lib.rs Resolved
🤖 Remove the usize::MAX resize call from the shared GlobalAlloc tests because its rounded size violates the trait's unsafe preconditions. Keep the valid 4-EiB failure request and verify that the original allocation stays live.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 11, 2026 18:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The documentation uses an outdated dependency version and incorrectly ties owner publication to retained events, requiring updates to the examples, generated README, and matching test assertion.

2 open issues

Review effort: Balanced

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.9%. Comparing base (ff31146) to head (bb6a425).
⚠️ Report is 11 commits behind head on main.

❌ Your project check has failed because the head coverage (99.9%) is below the target coverage (100.0%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #976     +/-   ##
========================================
- Coverage   100.0%   99.9%   -0.1%     
========================================
  Files         798     831     +33     
  Lines       68902   71330   +2428     
========================================
+ Hits        68902   71321   +2419     
- Misses          0       9      +9     
Flag Coverage Δ
linux 100.0% <100.0%> (ø)
linux-arm 100.0% <100.0%> (ø)
scheduled ?
windows 99.9% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread crates/rallocator/src/allocator.rs Dismissed
Comment thread crates/rallocator/tests/mimalloc.rs Dismissed
Comment thread crates/rallocator/tests/mimalloc.rs Resolved
🤖 The Hello-write fixture now uses mocked process identity instead of native Windows security calls.
A socket-free handshake failure case rejects fabricated success without waiting for a test server.
Miri and mutation thresholds remain unchanged.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The allocator’s unsafe metadata lookup, cross-thread frees, and page reclamation require specialist review and platform CI results, with native runtime validation not performed in this review.

No open issues 🎉

Review effort: Balanced

🤖 The truncation regression previously waited forever when the client skipped its connection.
The fixture now uses mocked I/O and detects client completion before accept.
The Hello request and truncated-response checks remain intact.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 13, 2026 17:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because both collectors advance a shared snapshot counter, potentially causing the second backend’s active owners to be misclassified as belonging to the previous round.

No open issues 🎉

Review effort: Balanced

🤖 The reconciliation test now uses mocked I/O and detects a client that returns without the second handshake.
This prevents the handshake mutation from leaving its server blocked in native accept.
The stop request, source failure and authoritative recording assertions remain intact.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 13, 2026 19:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The unsafe allocator’s cross-thread ownership and metadata-reclamation invariants require specialist soundness review and the pending macOS/ARM CI results.

No open issues 🎉

Review effort: Balanced

Preserve selectable backends, resize events, producer symbols and current-only snapshot formats. Move upstream regressions to their current owners and preserve the removal of HTML export.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 13, 2026 23:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Unsafe page metadata, cross-thread reclamation, and thread teardown require specialist review beyond the supplied hunks, with macOS and ARM validation still pending.

No open issues 🎉

Review effort: Balanced

Disable incremental test caches while preserving full debug symbols. Coverage builds each feature configuration in a fresh directory, so those caches only increase retained disk usage.

Construct checked NonNull pointers in the two allocator fixtures flagged by CodeQL, preserving their existing panic-on-null behavior without dismissing or suppressing the alerts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 13:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because shared round advancement across allocator backends can incorrectly classify current publications as previous-round data depending on collection order.

No open issues 🎉

Review effort: Balanced

@sandersaares

Copy link
Copy Markdown
Member

[Copilot speaking] ss-review-proactor is reserving this pull request for review with ss-review.

@sandersaares

Copy link
Copy Markdown
Member

[Copilot speaking]

Pull request overview (auto-generated).

Disabling test caches did not resolve hosted Windows disk exhaustion. Full collection retained much larger per-process coverage profiles and debug symbols, so avoid slowing developer test builds for an insufficient mitigation.

Keep the checked NonNull fixture construction, which passed CodeQL without alert dismissals or suppressions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 16:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because per-source advancement of the shared counter can misclassify publications from the latest request as previous-round data during combined backend captures.

No open issues 🎉

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants