Skip to content

fix(arty_executor): elide task builder lifetime - #986

Open
martintmk wants to merge 1 commit into
mainfrom
martintmk-fix-arty-executor-lint
Open

martintmk wants to merge 1 commit into
mainfrom
martintmk-fix-arty-executor-lint

Conversation

@martintmk

Copy link
Copy Markdown
Member

Fixes the Rust 1.97 clippy::elidable-lifetime-names failure in TaskBuilder.

The common builder methods now use an elided lifetime. The inspection-only method stays in a feature-gated implementation because its return type must preserve the named lifetime.

Validation:

  • cargo check -p arty_executor
  • cargo +1.97 clippy -p arty_executor --all-targets --locked -- -D warnings
  • cargo +1.97 clippy -p arty_executor --all-targets --all-features --locked -- -D warnings

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 14, 2026 07:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the TaskBuilder lifetime cleanup.

No open issues 🎉

What changed in this PR

Updates arty_executor::TaskBuilder to address Rust 1.97’s clippy::elidable-lifetime-names warning while preserving the lifetime required by inspection.

Changes:

  • Uses an elided lifetime for common builder methods.
  • Moves inspect into a separate implementation gated by the inspection feature, retaining its named lifetime.
File Description
crates/​arty_executor/​src/​task_builder.rs Separates common and inspection-only methods so only inspection retains a named lifetime.

Review effort: Balanced

@martintmk martintmk added the agency-rocket Touched by a rocket skill label Nov 14, 2026
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (6230675) to head (8b1b3d0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
  Coverage   100.0%   100.0%              
==========================================
  Files         791      138     -653     
  Lines       67488     8611   -58877     
==========================================
- Hits        67488     8611   -58877     
Flag Coverage Δ
linux 100.0% <ø> (ø)
linux-arm 100.0% <ø> (?)
scheduled ?
windows 100.0% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agency-rocket Touched by a rocket skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants