Repository navigation
fix(cli): respect npm registry config in update check - #484
Merged
Pavel Feldman (pavelfeldman) merged 2 commits intoOct 19, 2026
Merged
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
fix-478
branch
from
October 19, 2026 18:22
fa76527 to
a7234db
Compare
Yury Semikhatsky (yury-s)
approved these changes
Oct 19, 2026
| expect(npmRegistry.requests).toEqual(['/@playwright%2fcli']); | ||
| }); | ||
|
|
||
| test('update check on install does not warn about the skills being installed', async ({ npmRegistry }) => { |
There was a problem hiding this comment.
can we reduce number of the new tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm view @playwright/cli versioninstead of fetching registry.npmjs.org, so npm resolves the registry (incl.@playwright:registry), proxy and auth. Only onopen,attach,list,installandinstall-browserto contain the npm startup cost; failures and the 1.5s timeout stay silent.Fixes #478